mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Beata Michalska <beata.michalska@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, ionela.voinescu@arm.com,
	vanshikonda@os.amperecomputing.com
Cc: sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com,
	vincent.guittot@linaro.org, sumitg@nvidia.com,
	yang@os.amperecomputing.com, lihuisong@huawei.com
Subject: [PATCH v3 3/3] arm64: Update AMU-based frequency scale factor on entering idle
Date: Tue, 12 Mar 2024 08:34:31 +0000	[thread overview]
Message-ID: <20240312083431.3239989-4-beata.michalska@arm.com> (raw)
In-Reply-To: <20240312083431.3239989-1-beata.michalska@arm.com>

Now that the frequency scale factor has been activated for retrieving
current frequency on a given CPU, trigger its update upon entering
idle. This will, to an extent, allow querying last known frequency
in a non-invasive way. It will also improve the frequency scale factor
accuracy when a CPU entering idle did not receive a tick for a while.

Suggested-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Signed-off-by: Beata Michalska <beata.michalska@arm.com>
---
 arch/arm64/kernel/topology.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 42cb19c31719..77c6ac577cef 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -215,6 +215,18 @@ static struct scale_freq_data amu_sfd = {
 	.set_freq_scale = amu_scale_freq_tick,
 };
 
+void arch_cpu_idle_enter(void)
+{
+	unsigned int cpu = smp_processor_id();
+
+	if (!cpumask_test_cpu(cpu, amu_fie_cpus))
+		return;
+
+	/* Kick in AMU update but only if one has not happned already */
+	if (time_is_before_jiffies(per_cpu(cpu_amu_samples.last_update, cpu)))
+		amu_scale_freq_tick();
+}
+
 #define AMU_SAMPLE_EXP_MS	20
 
 unsigned int arch_freq_get_on_cpu(int cpu)
@@ -242,7 +254,8 @@ unsigned int arch_freq_get_on_cpu(int cpu)
 	 * try an alternative source for the counters (and thus freq scale),
 	 * if available for given policy
 	 */
-	if (time_is_before_jiffies(last_update + msecs_to_jiffies(AMU_SAMPLE_EXP_MS))) {
+	if (!idle_cpu(cpu) &&
+	    time_is_before_jiffies(last_update + msecs_to_jiffies(AMU_SAMPLE_EXP_MS))) {
 		struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
 		int ref_cpu = nr_cpu_ids;
 
-- 
2.25.1


  parent reply	other threads:[~2024-03-12  8:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  8:34 [PATCH v3 0/3] Add support for AArch64 AMUv1-based arch_freq_get_on_cpu Beata Michalska
2024-03-12  8:34 ` [PATCH v3 1/3] arch_topology: init capacity_freq_ref to 0 Beata Michalska
2024-03-12  8:34 ` [PATCH v3 2/3] arm64: Provide an AMU-based version of arch_freq_get_on_cpu Beata Michalska
2024-03-13  2:12   ` Vanshidhar Konda
2024-03-13 21:47     ` Beata Michalska
2024-03-13 12:20   ` Ionela Voinescu
2024-03-13 23:46     ` Beata Michalska
2024-03-18 15:01       ` Ionela Voinescu
2024-03-20 16:43   ` Sumit Gupta
2024-04-03 21:28     ` Beata Michalska
2024-03-12  8:34 ` Beata Michalska [this message]
2024-03-13 12:27 ` [PATCH v3 0/3] Add support for AArch64 AMUv1-based arch_freq_get_on_cpu Ionela Voinescu
2024-03-13 23:49   ` Beata Michalska
2024-03-20 16:52     ` Sumit Gupta
2024-04-03 21:30       ` Beata Michalska
2024-03-25 16:10 ` Vanshidhar Konda
2024-04-03 21:34   ` Beata Michalska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240312083431.3239989-4-beata.michalska@arm.com \
    --to=beata.michalska@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=lihuisong@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=sumitg@nvidia.com \
    --cc=vanshikonda@os.amperecomputing.com \
    --cc=vincent.guittot@linaro.org \
    --cc=will@kernel.org \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®