From: Joey Gouly <joey.gouly@arm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Shivansh Vij <shivanshvij@outlook.com>,
shivanshvij@loopholelabs.io,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
James Houghton <jthoughton@google.com>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Peter Collingbourne <pcc@google.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/mm: adds soft dirty page tracking
Date: Tue, 12 Mar 2024 10:26:09 +0000 [thread overview]
Message-ID: <20240312102609.GA1631865@e124191.cambridge.arm.com> (raw)
In-Reply-To: <ff65f353-6aa6-46a0-94fe-892e7b950d35@redhat.com>
On Tue, Mar 12, 2024 at 09:22:25AM +0100, David Hildenbrand wrote:
> On 12.03.24 02:16, Shivansh Vij wrote:
>
> Hi,
>
> > Checkpoint-Restore in Userspace (CRIU) needs to be able
> > to track a memory page's changes if we want to enable
> > pre-dumping, which is important for live migrations.
> >
> > The PTE_DIRTY bit (defined in pgtable-prot.h) is already
> > used to track software dirty pages, and the PTE_WRITE and
> > PTE_READ bits are used to track hardware dirty pages.
> >
> > This patch enables full soft dirty page tracking
> > (including swap PTE support) for arm64 systems, and is
> > based very closely on the x86 implementation.
> >
> > It is based on an unfinished patch by
> > Bin Lu (bin.lu@arm.com) from 2017
> > (https://patchwork.kernel.org/project/linux-arm-kernel/patch/1512029649-61312-1-git-send-email-bin.lu@arm.com/),
> > but has been updated for newer 6.x kernels as well as
> > tested on various 5.x kernels.
>
> There has also been more recently:
>
> https://lore.kernel.org/lkml/20230703135526.930004-1-npache@redhat.com/#r
>
> I recall that we are short on SW PTE bits:
>
> "
> So if you need software dirty, it can only be done with another software
> PTE bit. The problem is that we are short of such bits (only one left if
> we move PTE_PROT_NONE to a different location). The userfaultfd people
> also want such bit.
>
> Personally I'd reuse the four PBHA bits but I keep hearing that they may
> be used with some out of tree patches.
> "
>
> https://lore.kernel.org/lkml/ZLQIaSMI74KpqsQQ@arm.com/
>
I have some patches on the list (Permission Overlay) that also uses bit 60
series: https://lore.kernel.org/linux-arm-kernel/20231124163510.1835740-1-joey.gouly@arm.com/
commit: https://lore.kernel.org/linux-arm-kernel/20231124163510.1835740-9-joey.gouly@arm.com/
I will be sending out a v4 of that in several weeks.
Thanks,
Joey
next prev parent reply other threads:[~2024-03-12 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 1:16 Shivansh Vij
2024-03-12 8:22 ` David Hildenbrand
2024-03-12 10:26 ` Joey Gouly [this message]
2024-03-12 22:32 ` Shivansh Vij
2024-03-15 9:30 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312102609.GA1631865@e124191.cambridge.arm.com \
--to=joey.gouly@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=jthoughton@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=pcc@google.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=shivanshvij@loopholelabs.io \
--cc=shivanshvij@outlook.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®