From: "Köry Maincent" <kory.maincent@bootlin.com>
To: Elad Nachman <enachman@marvell.com>
Cc: <taras.chornyi@plvision.eu>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew@lunn.ch>, <thomas.petazzoni@bootlin.com>,
<miquel.raynal@bootlin.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] net: marvell: prestera: fix driver reload
Date: Tue, 12 Mar 2024 16:27:05 +0100 [thread overview]
Message-ID: <20240312162705.0097ee5a@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20240311135112.2642491-2-enachman@marvell.com>
On Mon, 11 Mar 2024 15:51:10 +0200
Elad Nachman <enachman@marvell.com> wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Driver rmmod after insmod would fail because of
> the following issues:
>
> 1. API call to reset the switch HW and restart the
> firmware CPU firmware code loading was missing in
> driver removal code handler.
> 2. Timeout waiting for the firmware CPU firmware
> loader code to start was too small.
>
> Fix by adding API call to reset the switch HW and
> restart the firmware CPU firmware code loading when
> handling the driver removal procedure,
> increase the timeout waiting for this restart operation
> from 5 to 30 seconds.
Tested-by: Kory Maincent <kory.maincent@bootlin.com>
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-03-12 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 13:51 [PATCH 0/3] Fix prestera driver fail to probe twice Elad Nachman
2024-03-11 13:51 ` [PATCH 1/3] net: marvell: prestera: fix driver reload Elad Nachman
2024-03-11 14:27 ` Andrew Lunn
2024-03-11 14:30 ` Denis Kirjanov
2024-03-11 14:36 ` Przemek Kitszel
2024-03-12 15:27 ` Köry Maincent [this message]
2024-03-11 13:51 ` [PATCH 2/3] net: marvell: prestera: fix memory use after free Elad Nachman
2024-03-12 15:45 ` Kory Maincent
2024-03-12 16:51 ` [EXTERNAL] " Elad Nachman
2024-03-11 13:51 ` [PATCH 3/3] net: marvell: prestera: force good base mac Elad Nachman
2024-03-11 14:29 ` Przemek Kitszel
2024-03-11 14:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240312162705.0097ee5a@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enachman@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=taras.chornyi@plvision.eu \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®