mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: John Stultz <jstultz@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org,
	Daniel Diaz <daniel.diaz@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>, Rae Moar <rmoar@google.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: [PATCH] kunit: time: Add faster unit test with shorter time range
Date: Wed, 13 Mar 2024 14:01:24 -0700	[thread overview]
Message-ID: <20240313210124.2858729-1-linux@roeck-us.net> (raw)

Commit a547c4ce10bd ("kunit: time: Mark test as slow using test
attributes") marked the time unit test as slow. This means it does not
run anymore if slow tests are disabled. This reduces test coverage and
is thus undesirable. At the same time, the test currently covers a range
of 160,000 years, which has limited value.

Add additional test case covering a total range of 1,600 years. This test
takes less than a second to run even on slow systems while still covering
twice the leap year calculation range of 400 years around the center date.
This test can run even with slow tests disabled.

Cc: Rae Moar <rmoar@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 kernel/time/time_test.c | 35 +++++++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 8 deletions(-)

diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
index 3e5d422dd15c..15c6f3a5e73c 100644
--- a/kernel/time/time_test.c
+++ b/kernel/time/time_test.c
@@ -47,18 +47,18 @@ static void advance_date(long *year, int *month, int *mday, int *yday)
 }
 
 /*
- * Checks every day in a 160000 years interval centered at 1970-01-01
+ * Checks every day in a specified interval centered at 1970-01-01
  * against the expected result.
  */
-static void time64_to_tm_test_date_range(struct kunit *test)
+static void time64_to_tm_test_date_range(struct kunit *test, int years)
 {
 	/*
-	 * 80000 years	= (80000 / 400) * 400 years
-	 *		= (80000 / 400) * 146097 days
-	 *		= (80000 / 400) * 146097 * 86400 seconds
+	 * years	= (years / 400) * 400 years
+	 *		= (years / 400) * 146097 days
+	 *		= (years / 400) * 146097 * 86400 seconds
 	 */
-	time64_t total_secs = ((time64_t) 80000) / 400 * 146097 * 86400;
-	long year = 1970 - 80000;
+	time64_t total_secs = ((time64_t) years) / 400 * 146097 * 86400;
+	long year = 1970 - years;
 	int month = 1;
 	int mdday = 1;
 	int yday = 0;
@@ -85,8 +85,27 @@ static void time64_to_tm_test_date_range(struct kunit *test)
 	}
 }
 
+ /*
+  * Checks every day in a 1600 years interval centered at 1970-01-01
+  * against the expected result.
+  */
+static void time64_to_tm_test_date_range_1600(struct kunit *test)
+{
+	time64_to_tm_test_date_range(test, 800);
+}
+
+ /*
+  * Checks every day in a 160000 years interval centered at 1970-01-01
+  * against the expected result.
+  */
+static void time64_to_tm_test_date_range_160000(struct kunit *test)
+{
+	time64_to_tm_test_date_range(test, 80000);
+}
+
 static struct kunit_case time_test_cases[] = {
-	KUNIT_CASE_SLOW(time64_to_tm_test_date_range),
+	KUNIT_CASE(time64_to_tm_test_date_range_1600),
+	KUNIT_CASE_SLOW(time64_to_tm_test_date_range_160000),
 	{}
 };
 
-- 
2.39.2


             reply	other threads:[~2024-03-13 21:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 21:01 Guenter Roeck [this message]
2024-03-14 19:05 ` Rae Moar
2024-03-14 19:30   ` Guenter Roeck
2024-03-14 19:44     ` Rae Moar
2024-03-14 22:08       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313210124.2858729-1-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=daniel.diaz@linaro.org \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmoar@google.com \
    --cc=sboyd@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®