From: Baokun Li <libaokun1@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
<ritesh.list@gmail.com>, <ojaswin@linux.ibm.com>,
<adobriyan@gmail.com>, <linux-kernel@vger.kernel.org>,
<yi.zhang@huawei.com>, <yangerkun@huawei.com>,
<libaokun1@huawei.com>
Subject: [PATCH v3 9/9] ext4: clean up s_mb_rb_lock to fix build warnings with C=1
Date: Thu, 14 Mar 2024 22:09:06 +0800 [thread overview]
Message-ID: <20240314140906.3064072-10-libaokun1@huawei.com> (raw)
In-Reply-To: <20240314140906.3064072-1-libaokun1@huawei.com>
Running sparse (make C=1) on mballoc.c we get the following warning:
fs/ext4/mballoc.c:3194:13: warning: context imbalance in
'ext4_mb_seq_structs_summary_start' - wrong count at exit
This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in
ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit
83e80a6e3543 ("ext4: use buckets for cr 1 block scan instead of rbtree"),
so remove the __acquires to silence the warning.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/mballoc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 48afe5aa228c..b3d616f055b0 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3190,7 +3190,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)
}
static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos)
-__acquires(&EXT4_SB(sb)->s_mb_rb_lock)
{
struct super_block *sb = pde_data(file_inode(seq->file));
unsigned long position;
--
2.31.1
prev parent reply other threads:[~2024-03-14 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 14:08 [PATCH v3 0/9] ext4: avoid sysfs variables overflow causing BUG_ON/SOOB Baokun Li
2024-03-14 14:08 ` [PATCH v3 1/9] ext4: avoid overflow when setting values via sysfs Baokun Li
2024-03-14 14:08 ` [PATCH v3 2/9] ext4: refactor out ext4_generic_attr_store() Baokun Li
2024-03-14 14:09 ` [PATCH v3 3/9] ext4: refactor out ext4_generic_attr_show() Baokun Li
2024-03-14 14:09 ` [PATCH v3 4/9] ext4: fix slab-out-of-bounds in ext4_mb_find_good_group_avg_frag_lists() Baokun Li
2024-03-18 12:39 ` Ojaswin Mujoo
2024-03-18 15:25 ` Jan Kara
2024-03-19 10:36 ` Ojaswin Mujoo
2024-03-19 10:05 ` Baokun Li
2024-03-19 18:25 ` Ojaswin Mujoo
2024-03-20 1:30 ` Baokun Li
2024-03-20 5:19 ` Ojaswin Mujoo
2024-03-14 14:09 ` [PATCH v3 5/9] ext4: add new attr pointer attr_mb_order Baokun Li
2024-03-14 14:09 ` [PATCH v3 6/9] ext4: add positive int attr pointer to avoid sysfs variables overflow Baokun Li
2024-03-14 14:09 ` [PATCH v3 7/9] ext4: set type of ac_groups_linear_remaining to __u32 to avoid overflow Baokun Li
2024-03-14 14:09 ` [PATCH v3 8/9] ext4: set the type of max_zeroout to unsigned int " Baokun Li
2024-03-14 14:09 ` Baokun Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240314140906.3064072-10-libaokun1@huawei.com \
--to=libaokun1@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=adobriyan@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®