From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D056B405FF; Fri, 15 Mar 2024 15:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710516281; cv=none; b=NK3n9LiAd8lXor5LKRxwRMEx8xrPulZ4keUswZCuH8o+p7XfRccHbYVrb9UIdMR/gpFunMcedd0WftRS0tcfFe6kMD4kNaoNdwNhSbgSOucy75uf5QS6aVdy64mDHKp1kDzgzruLCqKYBOKtsnhCuIQTY/35tR8JgHTkMlizmeM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710516281; c=relaxed/simple; bh=tvtPqHTyHAvq5sNabGjdAHpevyZoKTYNDRZhl/bZKTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I0hDFsYnFV++GN7OjEAHtZH160x8GoDLbdcl0EPfOO4PAheh1T1JkGzBDsm/8LL+L1Pc4zQgWcDxnC4UJqAl9Nlo4t3Ye5rdFG1Hl5lUN4J5FedkqUXHHdoBbA8hAKCXFl0zHjCYArYsbbLG4mY9Z/4nOkk24Ph+HhdUgfJr5t4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B10B3C15; Fri, 15 Mar 2024 08:25:12 -0700 (PDT) Received: from bogus (unknown [10.57.81.245]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EDD23F73F; Fri, 15 Mar 2024 08:24:34 -0700 (PDT) Date: Fri, 15 Mar 2024 15:24:31 +0000 From: Sudeep Holla To: Doug Anderson Cc: Maulik Shah , andersson@kernel.org, Sudeep Holla , ulf.hansson@linaro.org, swboyd@chromium.org, wingers@google.com, daniel.lezcano@linaro.org, rafael@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, jwerner@chromium.org, quic_lsrao@quicinc.com, quic_rjendra@quicinc.com, devicetree@vger.kernel.org, Abhinav Kumar , Jessica Zhang , Rob Clark Subject: Re: [RESEND v4 3/3] arm64: dts: qcom: sc7280: Add power-domains for cpuidle states Message-ID: <20240315152431.sckqhc6ri63blf2g@bogus> References: <20230703085555.30285-1-quic_mkshah@quicinc.com> <20230703085555.30285-4-quic_mkshah@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 14, 2024 at 04:20:59PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 3, 2023 at 1:56 AM Maulik Shah wrote: > > > > Add power-domains for cpuidle states to use psci os-initiated idle states. > > > > Cc: devicetree@vger.kernel.org > > Reviewed-by: Ulf Hansson > > Signed-off-by: Maulik Shah > > --- > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 98 +++++++++++++++++++++------- > > 1 file changed, 73 insertions(+), 25 deletions(-) > > FWIW, I dug up an old sc7280-herobrine board to test some other change > and found it no longer booted. :( I bisected it and this is the change > that breaks it. Specifically, I can make mainline boot with: > > git revert --no-edit db5d137e81bc # arm64: dts: qcom: sc7280: Update > domain-idle-states for cluster sleep > git revert --no-edit 7925ca85e956 # arm64: dts: qcom: sc7280: Add > power-domains for cpuidle states > IIRC, this could be issue with psci firmware. There were some known issues which were discussed few years back but I am not aware of the details and if/how it is applicable here. Not sure if you are getting any logs during the boot, if you do have worth look at logs related to PSCI/OSI/Idle/... -- Regards, Sudeep