From: Adam Butcher <adam@jessamine.co.uk>
To: broonie@kernel.org
Cc: adam@jessamine.co.uk, benjamin@bigler.one, carlos.song@nxp.com,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org,
stefanmoring@gmail.com
Subject: Re: [PATCH v2] spi: spi-imx: fix off-by-one in mx51 CPU mode burst length
Date: Mon, 18 Mar 2024 17:21:48 +0000 [thread overview]
Message-ID: <20240318172415.1588-1-adam@jessamine.co.uk> (raw)
In-Reply-To: <98914a36-e5dc-4f44-bf3e-c237d803a7e8@sirena.org.uk>
On Mon, March 18, 2024 3:55 pm, Mark Brown wrote:
> On Wed, Mar 13, 2024 at 08:58:19PM +0000, Adam Butcher wrote:
>> From: Adam Butcher <adam@jessamine.co.uk>
>>
>> 992e1211dc91 ("spi: imx: fix the burst length at DMA mode and CPU
>> mode") corrects three cases of setting the ECSPI burst length but
>> erroneously leaves the in-range CPU case one bit to big (in that
>> field a value of 0 means 1 bit). The effect was that transmissions
>> that should have been 8-bit bytes appeared as 9-bit causing failed
>> communication with SPI devices.
>
> This doesn't apply against current code, please check and resend.
>
That refers to the commit my patch fixes. On looking it up I found it
was no longer reachable
(https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?id=992e1211dc91).
The corresponding upstream commit that is reachable from both
torvalds/linux.git/master and broonie/spi.git/spi-next is c712c05e46c8.
Though it was made against 6.8.y, I was able to apply my patch with
git-am to both the latest broonie/spi.git/for-next (593c0afc18d) and
torvalds/linux.git/master (0a7b0acecea2) without conflicts.
Shall I send a v3 correcting the hash mentioned in the commit message?
next prev parent reply other threads:[~2024-03-18 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 20:58 Adam Butcher
2024-03-18 15:55 ` Mark Brown
2024-03-18 17:21 ` Adam Butcher [this message]
2024-03-18 17:33 ` Mark Brown
2024-03-19 11:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318172415.1588-1-adam@jessamine.co.uk \
--to=adam@jessamine.co.uk \
--cc=benjamin@bigler.one \
--cc=broonie@kernel.org \
--cc=carlos.song@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefanmoring@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®