From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Ye Bin <yebin10@huawei.com>, <mathieu.desnoyers@efficios.com>,
<linux-trace-kernel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 1/5] tracing/probes: support '%pd' type for print struct dentry's name
Date: Thu, 21 Mar 2024 11:46:36 -0400 [thread overview]
Message-ID: <20240321114636.5ed19630@gandalf.local.home> (raw)
In-Reply-To: <20240322000759.ec04bca3bb2afdfaef37a545@kernel.org>
On Fri, 22 Mar 2024 00:07:59 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > What would be really useful is if we had a way to expose BTF here. Something like:
> >
> > "%pB:<struct>:<field>"
> >
> > The "%pB" would mean to look up the struct/field offsets and types via BTF,
> > and create the appropriate command to find and print it.
>
> Would you mean casing the pointer to "<struct>"?
I mean, instead of having:
":%pd"
We could have:
"+0(*:%pB:dentry:name):string"
Where the parsing could use BTF to see that this is a pointer to "struct dentry"
and the member field is "name".
This would also allow pretty much any other structure dereference.
That is if BTF gives structure member offsets?
-- Steve
next prev parent reply other threads:[~2024-03-21 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 13:29 [PATCH v7 0/5] support '%pd' and '%pD' for print file name Ye Bin
2024-03-20 13:29 ` [PATCH v7 1/5] tracing/probes: support '%pd' type for print struct dentry's name Ye Bin
2024-03-21 14:15 ` Steven Rostedt
2024-03-21 15:07 ` Masami Hiramatsu
2024-03-21 15:28 ` Masami Hiramatsu
2024-03-21 15:48 ` Steven Rostedt
2024-03-21 15:46 ` Steven Rostedt [this message]
2024-03-20 13:29 ` [PATCH v7 2/5] tracing/probes: support '%pD' type for print struct file's name Ye Bin
2024-03-20 13:29 ` [PATCH v7 3/5] Documentation: tracing: add new type '%pd' and '%pD' for kprobe Ye Bin
2024-03-20 13:29 ` [PATCH v7 4/5] selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD" Ye Bin
2024-03-20 13:29 ` [PATCH v7 5/5] selftests/ftrace: add fprobe " Ye Bin
2024-03-21 14:01 ` [PATCH v7 0/5] support '%pd' and '%pD' for print file name Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321114636.5ed19630@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®