mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Moskalets <maximmosk4@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: maximmosk4@gmail.com, Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
Subject: [PATCH 4/8] module: replace seq_puts by seq_putc
Date: Tue, 26 Mar 2024 21:46:54 +0300	[thread overview]
Message-ID: <20240326184654.8700-1-Maxim.Moskalets@kaspersky.com> (raw)
In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com>

Using seq_putc for single characters is faster and more appropriate
than seq_puts, since only one character is passed and there is no need
to use a more powerful and less fast function.

Signed-off-by: Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
---
 kernel/module/procfs.c   | 4 ++--
 kernel/module/tracking.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/module/procfs.c b/kernel/module/procfs.c
index 0a4841e88adb..dc91d3dba8f3 100644
--- a/kernel/module/procfs.c
+++ b/kernel/module/procfs.c
@@ -35,7 +35,7 @@ static inline void print_unload_info(struct seq_file *m, struct module *mod)
 	}
 
 	if (!printed_something)
-		seq_puts(m, "-");
+		seq_putc(m, '-');
 }
 #else /* !CONFIG_MODULE_UNLOAD */
 static inline void print_unload_info(struct seq_file *m, struct module *mod)
@@ -99,7 +99,7 @@ static int m_show(struct seq_file *m, void *p)
 	if (mod->taints)
 		seq_printf(m, " %s", module_flags(mod, buf, true));
 
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
 	return 0;
 }
 
diff --git a/kernel/module/tracking.c b/kernel/module/tracking.c
index 16742d1c630c..dcc4dc4c7501 100644
--- a/kernel/module/tracking.c
+++ b/kernel/module/tracking.c
@@ -95,7 +95,7 @@ static int unloaded_tainted_modules_seq_show(struct seq_file *m, void *p)
 	buf[l++] = '\0';
 
 	seq_printf(m, "%s (%s) %llu", mod_taint->name, buf, mod_taint->count);
-	seq_puts(m, "\n");
+	seq_putc(m, '\n');
 
 	return 0;
 }
-- 
2.39.2


  parent reply	other threads:[~2024-03-26 18:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 18:45 [PATCH 0/8] kernel: " Maxim Moskalets
2024-03-26 18:45 ` [PATCH 1/8] bpf: " Maxim Moskalets
2024-03-26 18:45 ` [PATCH 2/8] cgroup: " Maxim Moskalets
2024-03-26 18:46 ` [PATCH 3/8] trace: " Maxim Moskalets
2024-03-26 18:46 ` Maxim Moskalets [this message]
2024-03-26 18:47 ` [PATCH 5/8] sched: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 6/8] locking: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 7/8] time: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 8/8] kernel: " Maxim Moskalets
2024-04-02  0:57 ` [PATCH 0/8] " Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326184654.8700-1-Maxim.Moskalets@kaspersky.com \
    --to=maximmosk4@gmail.com \
    --cc=Maxim.Moskalets@kaspersky.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®