mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dhruva Gole <d-gole@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] bus: ti-sysc: Drop legacy quirk handling for smartreflex
Date: Thu, 28 Mar 2024 16:53:51 +0530	[thread overview]
Message-ID: <20240328112351.e7klcl7zjz6uov2j@dhruva> (raw)
In-Reply-To: <20240327081508.36747-5-tony@atomide.com>

Hi,

On Mar 27, 2024 at 10:15:07 +0200, Tony Lindgren wrote:
> With the smartreflex driver no longer relying on the use of
> pm_runtime_irq_safe(), we can finally drop the related legacy quirk
> handling.

Just for some more context can you describe from which commit of
smartreflex driver did this happen?

> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  drivers/bus/ti-sysc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2869,8 +2869,7 @@ static const struct sysc_capabilities sysc_34xx_sr = {
>  	.type = TI_SYSC_OMAP34XX_SR,
>  	.sysc_mask = SYSC_OMAP2_CLOCKACTIVITY,
>  	.regbits = &sysc_regbits_omap34xx_sr,
> -	.mod_quirks = SYSC_QUIRK_USE_CLOCKACT | SYSC_QUIRK_UNCACHED |
> -		      SYSC_QUIRK_LEGACY_IDLE,
> +	.mod_quirks = SYSC_QUIRK_USE_CLOCKACT | SYSC_QUIRK_UNCACHED,
>  };
>  
>  /*
> @@ -2891,13 +2890,12 @@ static const struct sysc_capabilities sysc_36xx_sr = {
>  	.type = TI_SYSC_OMAP36XX_SR,
>  	.sysc_mask = SYSC_OMAP3_SR_ENAWAKEUP,
>  	.regbits = &sysc_regbits_omap36xx_sr,
> -	.mod_quirks = SYSC_QUIRK_UNCACHED | SYSC_QUIRK_LEGACY_IDLE,
> +	.mod_quirks = SYSC_QUIRK_UNCACHED,
>  };
>  
>  static const struct sysc_capabilities sysc_omap4_sr = {
>  	.type = TI_SYSC_OMAP4_SR,
>  	.regbits = &sysc_regbits_omap36xx_sr,
> -	.mod_quirks = SYSC_QUIRK_LEGACY_IDLE,

I'm good with the changes,
Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva

  reply	other threads:[~2024-03-28 11:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  8:15 [PATCH 0/5] Updates for ti-sysc interconnect target driver Tony Lindgren
2024-03-27  8:15 ` [PATCH 1/5] bus: ti-sysc: Move check for no-reset-on-init Tony Lindgren
2024-03-27  8:15 ` [PATCH 2/5] bus: ti-sysc: Add a description and copyrights Tony Lindgren
2024-03-28 11:19   ` Dhruva Gole
2024-03-28 11:36     ` Greg Kroah-Hartman
2024-03-28 11:47       ` Dhruva Gole
2024-03-28 11:38     ` Tony Lindgren
2024-03-27  8:15 ` [PATCH 3/5] bus: ti-sysc: Drop legacy quirk handling for uarts Tony Lindgren
2024-03-27  8:15 ` [PATCH 4/5] bus: ti-sysc: Drop legacy quirk handling for smartreflex Tony Lindgren
2024-03-28 11:23   ` Dhruva Gole [this message]
2024-03-28 11:34     ` Tony Lindgren
2024-03-27  8:15 ` [PATCH 5/5] bus: ti-sysc: Drop legacy idle quirk handling Tony Lindgren
2024-03-28 11:28   ` Dhruva Gole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328112351.e7klcl7zjz6uov2j@dhruva \
    --to=d-gole@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®