mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 5.4 12/23] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()
Date: Fri, 29 Mar 2024 08:49:45 -0400	[thread overview]
Message-ID: <20240329125009.3093845-12-sashal@kernel.org> (raw)
In-Reply-To: <20240329125009.3093845-1-sashal@kernel.org>

From: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>

[ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ]

In function get_pkg_num() if fopen_or_die() succeeds it returns a file
pointer to be used. But fclose() is never called before returning from
the function.

Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
index 3fe1eed900d41..165eb4da8a644 100644
--- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
+++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c
@@ -1111,6 +1111,7 @@ unsigned int get_pkg_num(int cpu)
 	retval = fscanf(fp, "%d\n", &pkg);
 	if (retval != 1)
 		errx(1, "%s: failed to parse", pathname);
+	fclose(fp);
 	return pkg;
 }
 
-- 
2.43.0


  parent reply	other threads:[~2024-03-29 12:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 12:49 [PATCH AUTOSEL 5.4 01/23] Input: synaptics-rmi4 - fail probing if memory allocation for "phys" fails Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 02/23] VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 03/23] sysv: don't call sb_bread() with pointers_lock held Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 04/23] quota: Fix potential NULL pointer dereference Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 05/23] scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 06/23] panic: Flush kernel log buffer at the end Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 07/23] isofs: handle CDs with bad root inode but good Joliet root directory Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 08/23] arm64: dts: rockchip: fix rk3328 hdmi ports node Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 09/23] arm64: dts: rockchip: fix rk3399 " Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 10/23] media: sta2x11: fix irq handler cast Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 11/23] drm/amd/display: Fix nanosec stat overflow Sasha Levin
2024-03-29 12:49 ` Sasha Levin [this message]
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 13/23] SUNRPC: increase size of rpc_wait_queue.qlen from unsigned short to unsigned int Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 14/23] Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default" Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 15/23] sparc: vdso: Disable UBSAN instrumentation Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 16/23] PCI: Mark LSI FW643 to avoid bus reset Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 17/23] sh: Fix build with CONFIG_UBSAN=y Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 18/23] btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 19/23] btrfs: export: handle invalid inode or root reference in btrfs_get_parent() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 20/23] btrfs: send: handle path ref underflow in header iterate_inode_ref() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 21/23] block: prevent division by zero in blk_rq_stat_sum() Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 22/23] Input: allocate keycode for Display refresh rate toggle Sasha Levin
2024-03-29 12:49 ` [PATCH AUTOSEL 5.4 23/23] ktest: force $buildonly = 1 for 'make_warnings_file' test type Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329125009.3093845-12-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=samasth.norway.ananda@oracle.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®