mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksandr Aprelkov <aaprelkov@usergate.com>
To: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Aleksandr Aprelkov <aaprelkov@usergate.com>,Pankaj Gupta
	<pankaj.gupta@nxp.com>,Gaurav Jain <gaurav.jain@nxp.com>,Herbert
	Xu <herbert@gondor.apana.org.au>,"David S. Miller"
	<davem@davemloft.net>,<linux-crypto@vger.kernel.org>,<linux-kernel@vger.kernel.org>,<lvc-project@linuxtesting.org>
Subject: [PATCH] crypto: caam/qi2 - check for 0 rx/tx  queues on setup
Date: Mon, 1 Apr 2024 15:26:20 +0700	[thread overview]
Message-ID: <20240401082620.608675-1-aaprelkov@usergate.com> (raw)

If num_rx_queues or num_tx_queues is 0, then division by zero occurs
on j calculation.
Also goto mark "err_get_rx_queue" used for tx queues too.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
Signed-off-by: Aleksandr Aprelkov <aaprelkov@usergate.com>
---
 drivers/crypto/caam/caamalg_qi2.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
index a4f6884416a0..07cb1aad758f 100644
--- a/drivers/crypto/caam/caamalg_qi2.c
+++ b/drivers/crypto/caam/caamalg_qi2.c
@@ -5049,6 +5049,11 @@ static int __cold dpaa2_dpseci_setup(struct fsl_mc_device *ls_dev)
 
 	priv->num_pairs = min(priv->dpseci_attr.num_rx_queues,
 			      priv->dpseci_attr.num_tx_queues);
+	if (!priv->num_pairs) {
+		err = -EINVAL;
+		dev_err(dev, "one of queues number is 0\n");
+		goto err_get_queues;
+	}
 	if (priv->num_pairs > num_online_cpus()) {
 		dev_warn(dev, "%d queues won't be used\n",
 			 priv->num_pairs - num_online_cpus());
@@ -5060,7 +5065,7 @@ static int __cold dpaa2_dpseci_setup(struct fsl_mc_device *ls_dev)
 					  &priv->rx_queue_attr[i]);
 		if (err) {
 			dev_err(dev, "dpseci_get_rx_queue() failed\n");
-			goto err_get_rx_queue;
+			goto err_get_queues;
 		}
 	}
 
@@ -5069,7 +5074,7 @@ static int __cold dpaa2_dpseci_setup(struct fsl_mc_device *ls_dev)
 					  &priv->tx_queue_attr[i]);
 		if (err) {
 			dev_err(dev, "dpseci_get_tx_queue() failed\n");
-			goto err_get_rx_queue;
+			goto err_get_queues;
 		}
 	}
 
@@ -5105,7 +5110,7 @@ static int __cold dpaa2_dpseci_setup(struct fsl_mc_device *ls_dev)
 
 	return 0;
 
-err_get_rx_queue:
+err_get_queues:
 	dpaa2_dpseci_congestion_free(priv);
 err_get_vers:
 	dpseci_close(priv->mc_io, 0, ls_dev->mc_handle);
-- 
2.34.1


             reply	other threads:[~2024-04-01  8:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01  8:26 Aleksandr Aprelkov [this message]
2024-04-01 14:22 ` Horia Geanta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240401082620.608675-1-aaprelkov@usergate.com \
    --to=aaprelkov@usergate.com \
    --cc=davem@davemloft.net \
    --cc=gaurav.jain@nxp.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=pankaj.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®