From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+fbf74291c3b7e753b481@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] possible deadlock in hsr_dev_xmit (2)
Date: Mon, 1 Apr 2024 21:03:28 +0800 [thread overview]
Message-ID: <20240401130328.3529-1-hdanton@sina.com> (raw)
In-Reply-To: <00000000000022c6b2061502dcbb@google.com>
On Sun, 31 Mar 2024 23:11:27 -0700
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 480e035fc4c7 Merge tag 'drm-next-2024-03-13' of https://gi..
> git tree: upstream
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15e0f5c3180000
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 480e035fc4c7
--- x/net/hsr/hsr_device.c
+++ y/net/hsr/hsr_device.c
@@ -226,9 +226,11 @@ static netdev_tx_t hsr_dev_xmit(struct s
skb->dev = master->dev;
skb_reset_mac_header(skb);
skb_reset_mac_len(skb);
- spin_lock_bh(&hsr->seqnr_lock);
+ local_bh_disable();
+ spin_lock_nested(&hsr->seqnr_lock, 1);
hsr_forward_skb(skb, master);
- spin_unlock_bh(&hsr->seqnr_lock);
+ spin_unlock(&hsr->seqnr_lock);
+ local_bh_enable();
} else {
dev_core_stats_tx_dropped_inc(dev);
dev_kfree_skb_any(skb);
--
next prev parent reply other threads:[~2024-04-01 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 14:20 syzbot
2024-04-01 6:11 ` syzbot
2024-04-01 13:03 ` Hillf Danton [this message]
2024-04-01 13:36 ` syzbot
2024-04-01 22:44 ` Hillf Danton
2024-04-02 3:26 ` syzbot
2024-05-05 9:08 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401130328.3529-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+fbf74291c3b7e753b481@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®