From: Hugo Villeneuve <hugo@hugovil.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 13/16] serial: max3100: Extract to_max3100_port() helper macro
Date: Tue, 2 Apr 2024 13:32:09 -0400 [thread overview]
Message-ID: <20240402133209.910f63378eb40fa27363f3ed@hugovil.com> (raw)
In-Reply-To: <20240402154219.3583679-14-andriy.shevchenko@linux.intel.com>
On Tue, 2 Apr 2024 18:38:19 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Instead of using container_of() explicitly, introduce a heler macro.
heler -> helper
Reviewed-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> This saves a lot of lines of code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/max3100.c | 67 ++++++++++--------------------------
> 1 file changed, 19 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 585bf6c898b2..19b05992a9ac 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -16,6 +16,7 @@
> /* 4 MAX3100s should be enough for everyone */
> #define MAX_MAX3100 4
>
> +#include <linux/container_of.h>
> #include <linux/delay.h>
> #include <linux/slab.h>
> #include <linux/device.h>
> @@ -110,6 +111,8 @@ struct max3100_port {
> struct timer_list timer;
> };
>
> +#define to_max3100_port(port) container_of(port, struct max3100_port, port)
> +
> static struct max3100_port *max3100s[MAX_MAX3100]; /* the chips */
> static DEFINE_MUTEX(max3100s_lock); /* race on probe */
>
> @@ -322,9 +325,7 @@ static irqreturn_t max3100_irq(int irqno, void *dev_id)
>
> static void max3100_enable_ms(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> mod_timer(&s->timer, jiffies);
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> @@ -332,9 +333,7 @@ static void max3100_enable_ms(struct uart_port *port)
>
> static void max3100_start_tx(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -343,9 +342,7 @@ static void max3100_start_tx(struct uart_port *port)
>
> static void max3100_stop_rx(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -359,9 +356,7 @@ static void max3100_stop_rx(struct uart_port *port)
>
> static unsigned int max3100_tx_empty(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -372,9 +367,7 @@ static unsigned int max3100_tx_empty(struct uart_port *port)
>
> static unsigned int max3100_get_mctrl(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -386,9 +379,7 @@ static unsigned int max3100_get_mctrl(struct uart_port *port)
>
> static void max3100_set_mctrl(struct uart_port *port, unsigned int mctrl)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
> int loopback, rts;
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> @@ -414,9 +405,7 @@ static void
> max3100_set_termios(struct uart_port *port, struct ktermios *termios,
> const struct ktermios *old)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
> unsigned int baud = port->uartclk / 16;
> unsigned int baud230400 = (baud == 230400) ? 1 : 0;
> unsigned cflag;
> @@ -532,9 +521,7 @@ max3100_set_termios(struct uart_port *port, struct ktermios *termios,
>
> static void max3100_shutdown(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
> u16 rx;
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> @@ -559,9 +546,7 @@ static void max3100_shutdown(struct uart_port *port)
>
> static int max3100_startup(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
> char b[12];
> int ret;
>
> @@ -607,9 +592,7 @@ static int max3100_startup(struct uart_port *port)
>
> static const char *max3100_type(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -618,18 +601,14 @@ static const char *max3100_type(struct uart_port *port)
>
> static void max3100_release_port(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> }
>
> static void max3100_config_port(struct uart_port *port, int flags)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
>
> @@ -640,9 +619,7 @@ static void max3100_config_port(struct uart_port *port, int flags)
> static int max3100_verify_port(struct uart_port *port,
> struct serial_struct *ser)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
> int ret = -EINVAL;
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> @@ -654,18 +631,14 @@ static int max3100_verify_port(struct uart_port *port,
>
> static void max3100_stop_tx(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> }
>
> static int max3100_request_port(struct uart_port *port)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> return 0;
> @@ -673,9 +646,7 @@ static int max3100_request_port(struct uart_port *port)
>
> static void max3100_break_ctl(struct uart_port *port, int break_state)
> {
> - struct max3100_port *s = container_of(port,
> - struct max3100_port,
> - port);
> + struct max3100_port *s = to_max3100_port(port);
>
> dev_dbg(&s->spi->dev, "%s\n", __func__);
> }
> --
> 2.43.0.rc1.1.gbec44491f096
>
>
--
Hugo Villeneuve
next prev parent reply other threads:[~2024-04-02 17:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:38 [PATCH v1 00/16] serial: max3100: Put into shape Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 01/16] serial: max3100: Lock port->lock when calling uart_handle_cts_change() Andy Shevchenko
2024-04-02 17:07 ` Hugo Villeneuve
2024-04-02 17:14 ` Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 02/16] serial: max3100: Update uart_driver_registered on driver removal Andy Shevchenko
2024-04-02 17:18 ` Hugo Villeneuve
2024-04-02 17:31 ` Andy Shevchenko
2024-04-02 17:37 ` Hugo Villeneuve
2024-04-02 15:38 ` [PATCH v1 03/16] serial: max3100: Fix bitwise types Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 04/16] serial: max3100: Make struct plat_max3100 local Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 05/16] serial: max3100: Remove custom HW shutdown support Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 06/16] serial: max3100: Replace custom polling timeout with standard one Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 07/16] serial: max3100: Enable TIOCM_LOOP Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 08/16] serial: max3100: Get crystal frequency via device property Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 09/16] serial: max3100: Remove duplicating irq field Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 10/16] serial: max3100: Switch to use dev_err_probe() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 11/16] serial: max3100: Replace MODULE_ALIAS() with respective ID tables Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 12/16] serial: max3100: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 13/16] serial: max3100: Extract to_max3100_port() helper macro Andy Shevchenko
2024-04-02 17:32 ` Hugo Villeneuve [this message]
2024-04-02 17:40 ` Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 14/16] serial: max3100: Remove unneeded forward declaration Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 15/16] serial: max3100: Sort headers Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 16/16] serial: max3100: Update Kconfig entry Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402133209.910f63378eb40fa27363f3ed@hugovil.com \
--to=hugo@hugovil.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®