From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andrew Halaney <ahalaney@redhat.com>
Subject: [PATCH v2 2/2] soc: qcom: pmic_glink: notify clients about the current state
Date: Wed, 03 Apr 2024 06:10:58 +0300 [thread overview]
Message-ID: <20240403-pmic-glink-fix-clients-v2-2-aed4e02baacc@linaro.org> (raw)
In-Reply-To: <20240403-pmic-glink-fix-clients-v2-0-aed4e02baacc@linaro.org>
In case the client is registered after the pmic-glink recived a response
from the Protection Domain mapper, it is going to miss the notification
about the state. Notify clients about the current state upon
registration.
Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/soc/qcom/pmic_glink.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c
index 2b2cdf479654..e85a12ec2aab 100644
--- a/drivers/soc/qcom/pmic_glink.c
+++ b/drivers/soc/qcom/pmic_glink.c
@@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_client(struct device *dev,
client->pdr_notify = pdr;
client->priv = priv;
+ mutex_lock(&pg->state_lock);
mutex_lock(&pg->client_lock);
+
list_add(&client->node, &pg->clients);
+ client->pdr_notify(client->priv, pg->client_state);
+
mutex_unlock(&pg->client_lock);
+ mutex_unlock(&pg->state_lock);
devres_add(dev, client);
--
2.39.2
next prev parent reply other threads:[~2024-04-03 3:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 3:10 [PATCH v2 0/2] soc: qcom: pmic_glink: fix client handling Dmitry Baryshkov
2024-04-03 3:10 ` [PATCH v2 1/2] soc: qcom: pmic_glink: don't traverse clients list without a lock Dmitry Baryshkov
2024-04-03 15:17 ` Andrew Halaney
2024-04-05 16:56 ` Mukesh Ojha
2024-04-03 3:10 ` Dmitry Baryshkov [this message]
2024-04-05 16:52 ` [PATCH v2 2/2] soc: qcom: pmic_glink: notify clients about the current state Mukesh Ojha
2024-04-05 15:43 ` [PATCH v2 0/2] soc: qcom: pmic_glink: fix client handling Xilin Wu
2024-04-21 22:29 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403-pmic-glink-fix-clients-v2-2-aed4e02baacc@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®