mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Daniel Sneddon <daniel.sneddon@linux.intel.com>,
	antonio.gomez.iglesias@linux.intel.com,
	alyssa.milburn@linux.intel.com, andrew.cooper3@citrix.com,
	linux-kernel@vger.kernel.org,
	Alyssa Milburn <alyssa.milburn@intel.com>,
	stable@kernel.org
Subject: Re: [PATCH v3] x86/bugs: Default retbleed to =stuff when retpoline is enabled
Date: Wed, 3 Apr 2024 07:50:49 -0700	[thread overview]
Message-ID: <20240403145049.ab7v436ntlw7xtty@desk> (raw)
In-Reply-To: <6ffcc9bd-039a-4ab4-a84d-eeedbc6fa1cc@suse.com>

On Wed, Apr 03, 2024 at 05:32:40PM +0300, Nikolay Borisov wrote:
> 
> 
> On 3.04.24 г. 8:54 ч., Pawan Gupta wrote:
> > On Intel systems when retpoline mitigation is enabled for spectre-v2,
> > retbleed=auto does not enable RSB stuffing. This may make the system
> > vulnerable to retbleed. Retpoline is not the default mitigation when
> > IBRS is present, but in virtualized cases a VMM can hide IBRS from
> > guests, resulting in guest deploying retpoline by default. Even if IBRS
> > is enumerated, a user can still select spectre_v2=retpoline.
> > 
> > As with other mitigations, mitigate retbleed by default. On Intel
> > systems when retpoline is enabled, and retbleed mitigation is set to
> > auto, enable Call Depth Tracking and RSB stuffing i.e. retbleed=stuff
> > mitigation. For AMD/Hygon auto mode already selects the appropriate
> > mitigation.
> > 
> > Reported-by: Alyssa Milburn <alyssa.milburn@intel.com>
> > Cc: stable@kernel.org
> > Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
> 
> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>

Thanks.

      reply	other threads:[~2024-04-03 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03  5:54 Pawan Gupta
2024-04-03 14:32 ` Nikolay Borisov
2024-04-03 14:50   ` Pawan Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403145049.ab7v436ntlw7xtty@desk \
    --to=pawan.kumar.gupta@linux.intel.com \
    --cc=alyssa.milburn@intel.com \
    --cc=alyssa.milburn@linux.intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=antonio.gomez.iglesias@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=peterz@infradead.org \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®