From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
alexandre.torgue@foss.st.com, andrew@lunn.ch, cjubran@nvidia.com,
corbet@lwn.net, davem@davemloft.net, dtatulea@nvidia.com,
edumazet@google.com, gal@nvidia.com, hkallweit1@gmail.com,
jacob.e.keller@intel.com, jiri@resnulli.us, joabreu@synopsys.com,
justinstitt@google.com, kory.maincent@bootlin.com,
kuba@kernel.org, leon@kernel.org, liuhangbin@gmail.com,
maxime.chevallier@bootlin.com, pabeni@redhat.com,
paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
rdunlap@infradead.org, richardcochran@gmail.com,
saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev,
vladimir.oltean@nxp.com, wojciech.drewek@intel.com,
Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: [PATCH net-next v2 0/6] ethtool HW timestamping statistics
Date: Wed, 3 Apr 2024 14:28:38 -0700 [thread overview]
Message-ID: <20240403212931.128541-1-rrameshbabu@nvidia.com> (raw)
The goal of this patch series is to introduce a common set of ethtool statistics
for hardware timestamping that a driver implementer can hook into. The
statistics counters added are based on what I believe are common
patterns/behaviors found across various hardware timestamping implementations
seen in the kernel tree today. The mlx5 family of devices is used as the PoC for
this patch series. Other vendors are more than welcome to chime in on this
series.
Changes since RFC v1:
- Dropped the late statistics counter since that was not general enough
- Dropped the layer selection attribute for timestamping statistics
- Take Jakub's suggestion and converted to ETHTOOL_FLAG_STATS
- Provided a working interface to query these new statistics from
tools/net/ynl/ethtool.py
Changes since RFC v2:
- Applied suggestion by Jakub for implementing an enumeration for
ethtool header flags
Changes since v1:
- Fixed scripts/kernel-doc warning in include/linux/ethtool.h
Link: https://lore.kernel.org/netdev/20240402205223.137565-1-rrameshbabu@nvidia.com/
Link: https://lore.kernel.org/netdev/20240309084440.299358-1-rrameshbabu@nvidia.com/
Link: https://lore.kernel.org/netdev/20240223192658.45893-1-rrameshbabu@nvidia.com/
Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
---
Rahul Rameshbabu (6):
ethtool: add interface to read Tx hardware timestamping statistics
net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port
timestamping CQ
net/mlx5e: Introduce timestamps statistic counter for Tx DMA layer
net/mlx5e: Implement ethtool hardware timestamping statistics
netlink: specs: ethtool: add header-flags enumeration
tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get
operation
Documentation/netlink/specs/ethtool.yaml | 22 ++++++++
.../ethernet/mellanox/mlx5/counters.rst | 11 ++++
Documentation/networking/ethtool-netlink.rst | 9 ++++
.../net/ethernet/mellanox/mlx5/core/en/ptp.c | 1 +
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 9 ++++
.../ethernet/mellanox/mlx5/core/en_stats.c | 48 +++++++++++++++++
.../ethernet/mellanox/mlx5/core/en_stats.h | 4 ++
.../net/ethernet/mellanox/mlx5/core/en_tx.c | 6 ++-
include/linux/ethtool.h | 27 +++++++++-
include/uapi/linux/ethtool_netlink.h | 25 ++++++---
net/ethtool/tsinfo.c | 52 ++++++++++++++++++-
tools/net/ynl/ethtool.py | 11 +++-
12 files changed, 214 insertions(+), 11 deletions(-)
--
2.42.0
next reply other threads:[~2024-04-03 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 21:28 Rahul Rameshbabu [this message]
2024-04-03 21:28 ` [PATCH net-next v2 1/6] ethtool: add interface to read Tx hardware " Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 2/6] net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port timestamping CQ Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 3/6] net/mlx5e: Introduce timestamps statistic counter for Tx DMA layer Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 4/6] net/mlx5e: Implement ethtool hardware timestamping statistics Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 5/6] netlink: specs: ethtool: add header-flags enumeration Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH RFC v2 5/6] tools: ynl: ethtool.py: Make tool invokable from any CWD Rahul Rameshbabu
2024-04-03 21:34 ` Rahul Rameshbabu
2024-04-03 21:28 ` [PATCH net-next v2 6/6] tools: ynl: ethtool.py: Output timestamping statistics from tsinfo-get operation Rahul Rameshbabu
2024-04-06 6:10 ` [PATCH net-next v2 0/6] ethtool HW timestamping statistics patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403212931.128541-1-rrameshbabu@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=joabreu@synopsys.com \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
--cc=saeed@kernel.org \
--cc=tariqt@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®