mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: catalin.marinas@arm.com, will@kernel.org, gshan@redhat.com,
	akpm@linux-foundation.org, maz@kernel.org,
	oliver.upton@linux.dev, ryan.roberts@arm.com, apopple@nvidia.com,
	rananta@google.com, mark.rutland@arm.com, v-songbaohua@oppo.com,
	yangyicong@hisilicon.com, shahuang@redhat.com, yihyu@redhat.com,
	shan.gavin@gmail.com
Subject: [PATCH v3 0/3] arm64: tlb: Fix TLBI RANGE operand
Date: Fri,  5 Apr 2024 13:58:49 +1000	[thread overview]
Message-ID: <20240405035852.1532010-1-gshan@redhat.com> (raw)

A kernel crash on the destination VM after the live migration was
reported by Yihuang Yu. The issue is only reproducible on NVidia's
grace-hopper where TLBI RANGE feature is available. The kernel crash
is caused by incomplete TLB flush and missed dirty page. For the
root cause and analysis, please refer to PATCH[v3 1/3]'s commit log.

Thanks to Marc Zyngier who proposed all the code changes.

PATCH[1] fixes the kernel crash by extending __TLBI_RANGE_NUM() so that
         the TLBI RANGE on the area with MAX_TLBI_RANGE_PAGES pages can
         be supported
PATCH[2] improves __TLBI_VADDR_RANGE() with masks and FIELD_PREP()
PATCH[3] allows TLBI RANGE operation on the area with MAX_TLBI_RANGE_PAGES
         pages in __flush_tlb_range_nosync()

v2: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/917432.html
v1: https://lists.infradead.org/pipermail/linux-arm-kernel/2024-April/916972.html

Changelog
=========
v3:
  Improve __TLBI_RANGE_NUM() and its comments. Added patches
  to improve __TLBI_VADDR_RANGE() and __flush_tlb_range_nosync() (Marc) 
v2:
  Improve __TLBI_RANGE_NUM()                                     (Marc)

Gavin Shan (3):
  arm64: tlb: Fix TLBI RANGE operand
  arm64: tlb: Improve __TLBI_VADDR_RANGE()
  arm64: tlb: Allow range operation for MAX_TLBI_RANGE_PAGES

 arch/arm64/include/asm/tlbflush.h | 53 ++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 22 deletions(-)

-- 
2.44.0


             reply	other threads:[~2024-04-05  3:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05  3:58 Gavin Shan [this message]
2024-04-05  3:58 ` [PATCH v3 1/3] " Gavin Shan
2024-04-05 17:10   ` Catalin Marinas
2024-04-08  8:29   ` Ryan Roberts
2024-04-10  8:45     ` Marc Zyngier
2024-04-11  9:59       ` Ryan Roberts
2024-04-10  7:55   ` Anshuman Khandual
2024-04-05  3:58 ` [PATCH v3 2/3] arm64: tlb: Improve __TLBI_VADDR_RANGE() Gavin Shan
2024-04-05 17:10   ` Catalin Marinas
2024-04-08  8:31   ` Ryan Roberts
2024-04-10  7:57   ` Anshuman Khandual
2024-04-05  3:58 ` [PATCH v3 3/3] arm64: tlb: Allow range operation for MAX_TLBI_RANGE_PAGES Gavin Shan
2024-04-05 17:12   ` Catalin Marinas
2024-04-08  8:43   ` Ryan Roberts
2024-04-10  8:50     ` Marc Zyngier
2024-04-11 10:44       ` Will Deacon
2024-04-10  7:58   ` Anshuman Khandual
2024-04-10  8:43 ` [PATCH v3 0/3] arm64: tlb: Fix TLBI RANGE operand Shaoqin Huang
2024-04-10 17:52 ` (subset) " Catalin Marinas
2024-04-12 16:06 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405035852.1532010-1-gshan@redhat.com \
    --to=gshan@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=rananta@google.com \
    --cc=ryan.roberts@arm.com \
    --cc=shahuang@redhat.com \
    --cc=shan.gavin@gmail.com \
    --cc=v-songbaohua@oppo.com \
    --cc=will@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=yihyu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®