From: "Paweł Anikiel" <panikiel@google.com>
To: kieran.bingham@ideasonboard.com, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, tharvey@gateworks.com,
niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com,
charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com,
jonathanh@nvidia.com, skomatineni@nvidia.com,
luca.ceresoli@bootlin.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
chromeos-krk-upstreaming@google.com,
"Paweł Anikiel" <panikiel@google.com>
Subject: [PATCH 01/16] media: v4l2-subdev: Add pad versions of dv timing subdev calls
Date: Fri, 5 Apr 2024 14:13:56 +0000 [thread overview]
Message-ID: <20240405141411.1807189-2-panikiel@google.com> (raw)
In-Reply-To: <20240405141411.1807189-1-panikiel@google.com>
Currently, subdev dv timing calls (i.e. g/s/query_dv_timings) are video
ops without a pad argument. This is a problem if the subdevice can have
different dv timings for each pad (e.g. a DisplayPort receiver with
multiple virtual channels).
To solve this, change these calls to include a pad argument, and put
them into pad ops. Keep the old ones temporarily to make the switch
easier.
Signed-off-by: Paweł Anikiel <panikiel@google.com>
---
drivers/media/v4l2-core/v4l2-subdev.c | 33 +++++++++++++++++++++++++++
include/media/v4l2-subdev.h | 14 ++++++++++++
2 files changed, 47 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 4c6198c48dd6..07759cdd0844 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -369,6 +369,36 @@ static int call_set_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid)
return check_edid(sd, edid) ? : sd->ops->pad->set_edid(sd, edid);
}
+static int call_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings)
+{
+ if (!timings)
+ return -EINVAL;
+
+ return check_pad(sd, pad) ? :
+ sd->ops->pad->s_dv_timings(sd, pad, timings);
+}
+
+static int call_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings)
+{
+ if (!timings)
+ return -EINVAL;
+
+ return check_pad(sd, pad) ? :
+ sd->ops->pad->g_dv_timings(sd, pad, timings);
+}
+
+static int call_query_dv_timings(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings)
+{
+ if (!timings)
+ return -EINVAL;
+
+ return check_pad(sd, pad) ? :
+ sd->ops->pad->query_dv_timings(sd, pad, timings);
+}
+
static int call_dv_timings_cap(struct v4l2_subdev *sd,
struct v4l2_dv_timings_cap *cap)
{
@@ -487,6 +517,9 @@ static const struct v4l2_subdev_pad_ops v4l2_subdev_call_pad_wrappers = {
.set_frame_interval = call_set_frame_interval,
.get_edid = call_get_edid,
.set_edid = call_set_edid,
+ .s_dv_timings = call_s_dv_timings,
+ .g_dv_timings = call_g_dv_timings,
+ .query_dv_timings = call_query_dv_timings,
.dv_timings_cap = call_dv_timings_cap,
.enum_dv_timings = call_enum_dv_timings,
.get_frame_desc = call_get_frame_desc,
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index a9e6b8146279..a5213411ef2b 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -791,6 +791,14 @@ struct v4l2_subdev_state {
*
* @set_edid: callback for VIDIOC_SUBDEV_S_EDID() ioctl handler code.
*
+ * @s_dv_timings: Set custom dv timings in the sub device. This is used
+ * when sub device is capable of setting detailed timing information
+ * in the hardware to generate/detect the video signal.
+ *
+ * @g_dv_timings: Get custom dv timings in the sub device.
+ *
+ * @query_dv_timings: callback for VIDIOC_QUERY_DV_TIMINGS() ioctl handler code.
+ *
* @dv_timings_cap: callback for VIDIOC_SUBDEV_DV_TIMINGS_CAP() ioctl handler
* code.
*
@@ -864,6 +872,12 @@ struct v4l2_subdev_pad_ops {
struct v4l2_subdev_frame_interval *interval);
int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_edid *edid);
int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_edid *edid);
+ int (*s_dv_timings)(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings);
+ int (*g_dv_timings)(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings);
+ int (*query_dv_timings)(struct v4l2_subdev *sd, unsigned int pad,
+ struct v4l2_dv_timings *timings);
int (*dv_timings_cap)(struct v4l2_subdev *sd,
struct v4l2_dv_timings_cap *cap);
int (*enum_dv_timings)(struct v4l2_subdev *sd,
--
2.44.0.478.gd926399ef9-goog
next prev parent reply other threads:[~2024-04-05 14:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 14:13 [PATCH 00/16] Switch subdev dv timing callbacks to pad ops Paweł Anikiel
2024-04-05 14:13 ` Paweł Anikiel [this message]
2024-04-05 14:13 ` [PATCH 02/16] media: i2c: adv748x: Switch " Paweł Anikiel
2024-04-06 14:04 ` Niklas Söderlund
2024-04-05 14:13 ` [PATCH 03/16] media: i2c: adv7511: " Paweł Anikiel
2024-04-05 14:13 ` [PATCH 04/16] media: i2c: adv7604: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 05/16] media: i2c: adv7842: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 06/16] media: i2c: tc358743: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 07/16] media: i2c: tda1997x: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 08/16] media: i2c: ths7303: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 09/16] media: i2c: ths8200: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 10/16] media: i2c: tvp7002: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 11/16] media: spi: gs1662: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 12/16] media: cobalt: Use pad variant of dv timing subdev calls Paweł Anikiel
2024-04-05 14:14 ` [PATCH 13/16] media: rcar-vin: " Paweł Anikiel
2024-04-06 14:03 ` Niklas Söderlund
2024-04-05 14:14 ` [PATCH 14/16] media: vpif_capture: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 15/16] media: tegra-video: " Paweł Anikiel
2024-04-05 14:14 ` [PATCH 16/16] media: v4l2-subdev: Remove non-pad dv timing callbacks Paweł Anikiel
2024-04-08 14:15 ` [PATCH 00/16] Switch subdev dv timing callbacks to pad ops Hans Verkuil
2024-04-08 14:17 ` Hans Verkuil
2024-04-08 15:25 ` Paweł Anikiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405141411.1807189-2-panikiel@google.com \
--to=panikiel@google.com \
--cc=charles-antoine.couret@nexvision.fr \
--cc=chromeos-krk-upstreaming@google.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=prabhakar.csengg@gmail.com \
--cc=skomatineni@nvidia.com \
--cc=tharvey@gateworks.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®