From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 3/3] media: videodev2: Fix v4l2_ext-control packing.
Date: Wed, 10 Apr 2024 12:24:39 +0000 [thread overview]
Message-ID: <20240410-pack-v1-3-70f287dd8a66@chromium.org> (raw)
In-Reply-To: <20240410-pack-v1-0-70f287dd8a66@chromium.org>
The structure is packed, which requires that all its fields need to be
also packed.
./include/uapi/linux/videodev2.h:1810:2: warning: field within 'struct v4l2_ext_control' is less aligned than 'union v4l2_ext_control::(anonymous at ./include/uapi/linux/videodev2.h:1810:2)' and is usually due to 'struct v4l2_ext_control' being packed, which can lead to unaligned accesses [-Wunaligned-access]
Explicitly set the inner union as packed.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
include/uapi/linux/videodev2.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 2663213b76a49..bf12860d570af 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -1842,7 +1842,7 @@ struct v4l2_ext_control {
struct v4l2_ctrl_hdr10_cll_info __user *p_hdr10_cll_info;
struct v4l2_ctrl_hdr10_mastering_display __user *p_hdr10_mastering_display;
void __user *ptr;
- };
+ } __attribute__ ((packed));
} __attribute__ ((packed));
struct v4l2_ext_controls {
--
2.44.0.478.gd926399ef9-goog
prev parent reply other threads:[~2024-04-10 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 12:24 [PATCH 0/3] media: Fix missing warnings for llvm am32 Ricardo Ribalda
2024-04-10 12:24 ` [PATCH 1/3] media: dvb: as102-fe: Fix as10x_register_addr packing Ricardo Ribalda
2024-04-12 14:19 ` Hans Verkuil
2024-04-10 12:24 ` [PATCH 2/3] media: dvb: Fix dtvs_stats packing Ricardo Ribalda
2024-04-12 14:21 ` Hans Verkuil
2024-04-12 15:00 ` Ricardo Ribalda
2024-04-15 9:51 ` Hans Verkuil
2024-04-15 10:29 ` Ricardo Ribalda
2024-04-10 12:24 ` Ricardo Ribalda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410-pack-v1-3-70f287dd8a66@chromium.org \
--to=ribalda@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®