From: Pin-yen Lin <treapking@chromium.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Alexandre Mergnat" <amergnat@baylibre.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Minjie Du" <duminjie@vivo.com>,
linux-pm@vger.kernel.org,
"Frank Wunderlich" <frank-w@public-files.de>,
"Balsam CHIHI" <bchihi@baylibre.com>,
"Pin-yen Lin" <treapking@chromium.org>
Subject: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove redundant code in lvts_ctrl_configure
Date: Wed, 10 Apr 2024 08:07:28 +0800 [thread overview]
Message-ID: <20240410000730.628043-1-treapking@chromium.org> (raw)
The removed variable assignment is never written to the register, so it
has no effect on the device behavior. Mediatek has confirmed that it
is not required to initialize this register for current platforms, so
remove this segment to avoid confusion.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
drivers/thermal/mediatek/lvts_thermal.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index fd4bd650c77a..48d2f8ba3f18 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -985,12 +985,6 @@ static int lvts_ctrl_configure(struct device *dev, struct lvts_ctrl *lvts_ctrl)
value = LVTS_TSSEL_CONF;
writel(value, LVTS_TSSEL(lvts_ctrl->base));
- /*
- * LVTS_CALSCALE : ADC voltage round
- */
- value = 0x300;
- value = LVTS_CALSCALE_CONF;
-
/*
* LVTS_MSRCTL0 : Sensor filtering strategy
*
--
2.44.0.478.gd926399ef9-goog
next reply other threads:[~2024-04-10 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 0:07 Pin-yen Lin [this message]
2024-04-10 4:38 ` Chen-Yu Tsai
2024-04-10 9:55 ` AngeloGioacchino Del Regno
2025-04-30 8:25 ` Chang-Yi Lin (林長億)
2025-05-14 19:49 ` Pin-yen Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410000730.628043-1-treapking@chromium.org \
--to=treapking@chromium.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=duminjie@vivo.com \
--cc=frank-w@public-files.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®