From: Conor Dooley <conor.dooley@microchip.com>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: Conor Dooley <conor@kernel.org>,
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] cache: sifive_ccache: Auxiliary device support
Date: Fri, 12 Apr 2024 13:51:45 +0100 [thread overview]
Message-ID: <20240412-antacid-pretzel-c25d707f02cf@wendy> (raw)
In-Reply-To: <20240410232211.438277-1-samuel.holland@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
On Wed, Apr 10, 2024 at 04:22:02PM -0700, Samuel Holland wrote:
> As of commit c90847bcbfb6 ("cache: sifive_ccache: Partially convert to a
> platform driver"), the cache subsystem binds a platform driver to the
> Composable Cache's DT node. This prevents the perf subsystem from doing
> the same for the new PMU driver[1]. To allow using both drivers at the
> same time without conflicts or module linkage dependencies, attach the
> PMU driver to the auxiliary device bus. While at it, prepare to use the
> auxiliary device bus for the EDAC driver as well, which significantly
> simplifies that driver. The actual EDAC driver conversion has to wait
> another development cycle to avoid dependencies between git trees.
I'm not really keen on the partial conversion, I'd like to see a
complete conversion where the ccache driver calls
"sifive_register_ccache_pmu()" and "sifive_register_ccache_edac()"
and has no part in creating the aux device itself, like Philipp and
Stephen asked me to do here for the clock/reset drivers on PolarFire SoC:
https://lore.kernel.org/all/20240409-shallow-voice-c84ed791bc7d@spud/
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-12 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 23:22 Samuel Holland
2024-04-10 23:22 ` [PATCH 1/4] cache: sifive_ccache: Silence unused variable warning Samuel Holland
2024-04-10 23:22 ` [PATCH 2/4] cache: sifive_ccache: Use of_iomap() helper Samuel Holland
2024-04-10 23:22 ` [PATCH 3/4] cache: sifive_ccache: Export base address for child drivers Samuel Holland
2024-04-10 23:22 ` [PATCH 4/4] cache: sifive_ccache: Add EDAC and PMU as auxiliary devices Samuel Holland
2024-04-12 12:51 ` Conor Dooley [this message]
2024-04-24 20:19 ` [PATCH 0/4] cache: sifive_ccache: Auxiliary device support Alexandre Ghiti
2024-04-24 21:20 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412-antacid-pretzel-c25d707f02cf@wendy \
--to=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®