From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24AF284DF6 for ; Fri, 12 Apr 2024 14:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712931659; cv=none; b=DsG7FryVuDR3ZX32aCyRHCHeoaha7Wfs9jpTIHJbpAo4WxetjaCc91kxTC8y7BhIGTYRViXwTXvk6aem3J0duDRSTZUWA2Dtvd2rQ3I33IRvvockp9atRpX4XtOLEaBffCCYgc6q/MeJmR0Cejh19gb4FRMaeZhVuaTKBUkti2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712931659; c=relaxed/simple; bh=UP+cGmNiYoAwGW8m8W6yr/q48Hsj4d5EwX9JW9HfKBw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DLj97cLgul9uySbu3V2rprSREN78+Lyif/nSOq4RHVejMPV7vG2lARSc+b6FJr5f410cXBcg0Q1vdME5ZEz+5sF+52w5Pxpddw7SW8ea2INgmUHra4EH8cTbsahO2Y14mfvGcy4XgqwLHybDIos9mHCHZ8lQ/GAYiFW9Lb3kLDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cORVpr7V; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cORVpr7V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712931657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qgw0vEZxafA068CWQUUNtsQrgIh5CdevYV3sXi6m8+Q=; b=cORVpr7VYzrcPSSyVnIHQoa4M9WyR7GpwyTbpiykR8fzDaSf5lo9WHTkrcMTdYlgvqwa3N mhJyA7evgFxZr1j4G73aUQWsTExl6F47ywyXqobSiT9BciN2wc6y+RZjwY+udEmKsR7418 CJSn2Hx0XeE7+RPkVhXV8WXRn/5fnD4= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-gR68dQzJMImFwvzbnXHfWw-1; Fri, 12 Apr 2024 10:20:55 -0400 X-MC-Unique: gR68dQzJMImFwvzbnXHfWw-1 Received: by mail-il1-f198.google.com with SMTP id e9e14a558f8ab-36a38d56655so10721665ab.0 for ; Fri, 12 Apr 2024 07:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931655; x=1713536455; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Qgw0vEZxafA068CWQUUNtsQrgIh5CdevYV3sXi6m8+Q=; b=Vma9SBKXuynCCpuDTtRKq5ZOt+5df543uhNOVKEFZXr6tGtCw7xaqpsQhFZtB4ngPc iB39F+1oqkl4C3PBDS/Xm0DqoC4jGmXSeHSbozgdXLxFPdEt9I0xELOaOUPXHWvPyjcA 93tyRChSDuGYNpVTsgu30dfQBKXtr8OXEeGukyxaSUWStTSyEJAColxebfGlhY8KzBFe +0N8k7O6Qd/XVxv52bpzoh+iXb3UNmvI9EWoNIr26DpbrQRKS5ncakbEOg1+r5cvFYxm /pe929vagOaUCaP4S4R1LVzDusoN2ooKh2wUSDNprGzCU2Ed9PrewORJZKEUeKkvgLaF g3ag== X-Forwarded-Encrypted: i=1; AJvYcCXh94DfHD3l913R6tP1lkDpz5DHc1QO+vjj9tHVrF/i/6O+W8injovIK/RswcKI+zXAVSgZanN0Yv+o4uG+1nC0xGcibuFKjo/ZOO7G X-Gm-Message-State: AOJu0YzbfEEr7Jww/xFUlKI97yyVZQKb7okEUJImfepDIkOsYPYSv9GT klgwlX9b2UwCtWP4TO2bv56FFfVrhGKFwOwZ/0CK2bUBISlgk+9OFQ0YSbGb0vGVwsdIZE9eFA4 z3eafeZyzzfabO4iXqrFTTCeO3Q8WCkC6HQE2fIG+9SrnKqR6shbuVbs5UoYnBw== X-Received: by 2002:a05:6e02:1b05:b0:36a:15bb:608c with SMTP id i5-20020a056e021b0500b0036a15bb608cmr3096346ilv.28.1712931655020; Fri, 12 Apr 2024 07:20:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4qm2aJCy42jLqJ2UrSQkuMIunPpATTlPV/ijXzsxxU6bggEIQyJkHYotnp6ZEyuowvnaGdg== X-Received: by 2002:a05:6e02:1b05:b0:36a:15bb:608c with SMTP id i5-20020a056e021b0500b0036a15bb608cmr3096329ilv.28.1712931654707; Fri, 12 Apr 2024 07:20:54 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id r12-20020a92ce8c000000b00368706996b8sm1000820ilo.38.2024.04.12.07.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:20:54 -0700 (PDT) Date: Fri, 12 Apr 2024 08:20:51 -0600 From: Alex Williamson To: JianChunfu Cc: cohuck@redhat.com, linux-kernel@vger.kernel.org, "kvm@vger.kernel.org" , Alexey Kardashevskiy Subject: Re: [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER_MEMORY Message-ID: <20240412082051.0f9959e3.alex.williamson@redhat.com> In-Reply-To: <20240412085333.1286724-1-chunfu.jian@shingroup.cn> References: <20240412085333.1286724-1-chunfu.jian@shingroup.cn> Organization: Red Hat Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 12 Apr 2024 16:53:33 +0800 JianChunfu wrote: > The type1 ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called > in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/ > VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description. This does not match my understanding of SPAPR which is that memory is registered for use by MAP_DMA/UNMAP_DMA calls, _CREATE and _REMOVE are used for managing DMA window apertures. Thanks, Alex > Signed-off-by: JianChunfu > --- > include/uapi/linux/vfio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index 2b68e6cdf..30efc8af4 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -1764,7 +1764,7 @@ struct vfio_eeh_pe_op { > * > * Registers user space memory where DMA is allowed. It pins > * user pages and does the locked memory accounting so > - * subsequent VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA calls > + * subsequent VFIO_IOMMU_SPAPR_TCE_CREATE/VFIO_IOMMU_SPAPR_TCE_REMOVE calls > * get faster. > */ > struct vfio_iommu_spapr_register_memory {