From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>,
Puneet Gupta <puneet.gupta@amd.com>,
Nipun Gupta <nipun.gupta@amd.com>,
linux-kernel@vger.kernel.org,
Abhijit Gangurde <abhijit.gangurde@amd.com>,
kernel@pengutronix.de,
Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Subject: Re: [PATCH] cdx: Convert to platform remove callback returning void
Date: Sat, 13 Apr 2024 12:41:21 +0200 [thread overview]
Message-ID: <2024041316-unwrapped-parchment-88d8@gregkh> (raw)
In-Reply-To: <wyt4jvdvbq4wrgxslwkdeg3e6mhjtfue4xwdec7sil3whhromv@57xjgduvont7>
On Sat, Apr 13, 2024 at 12:12:56PM +0200, Uwe Kleine-König wrote:
> Hello Greg,
>
> On Fri, Mar 08, 2024 at 09:51:05AM +0100, Uwe Kleine-König wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> we just talked in irc about this thread that might have fell through the
> cracks on your side.
>
> Thanks for reconsidering to apply it for v6.10-rc1,
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2024-04-13 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 Uwe Kleine-König
2024-03-14 8:31 ` Gupta, Nipun
2024-04-13 10:12 ` Uwe Kleine-König
2024-04-13 10:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041316-unwrapped-parchment-88d8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhijit.gangurde@amd.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nipun.gupta@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=puneet.gupta@amd.com \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®