From: Changbin Du <changbin.du@huawei.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Changbin Du <changbin.du@huawei.com>
Subject: [PATCH 2/4] perf trace beauty: Beautify newfstatat flags
Date: Thu, 18 Apr 2024 21:13:02 +0800 [thread overview]
Message-ID: <20240418131304.3188385-3-changbin.du@huawei.com> (raw)
In-Reply-To: <20240418131304.3188385-1-changbin.du@huawei.com>
Beautify the flags argument of newfstatat() using the same scnprintf
of statx().
Signed-off-by: Changbin Du <changbin.du@huawei.com>
---
tools/perf/builtin-trace.c | 3 ++-
tools/perf/trace/beauty/statx.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 90eaff8c0f6e..19e81a467d6a 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1050,7 +1050,8 @@ static const struct syscall_fmt syscall_fmts[] = {
{ .name = "name_to_handle_at",
.arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ }, }, },
{ .name = "newfstatat",
- .arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ }, }, },
+ .arg = { [0] = { .scnprintf = SCA_FDAT, /* dfd */ },
+ [3] = { .scnprintf = SCA_STATX_FLAGS, /* flags */ }, }, },
{ .name = "open",
.arg = { [1] = { .scnprintf = SCA_OPEN_FLAGS, /* flags */ }, }, },
{ .name = "open_by_handle_at",
diff --git a/tools/perf/trace/beauty/statx.c b/tools/perf/trace/beauty/statx.c
index c61f2be53bda..dd83a2a95d89 100644
--- a/tools/perf/trace/beauty/statx.c
+++ b/tools/perf/trace/beauty/statx.c
@@ -30,6 +30,7 @@ size_t syscall_arg__scnprintf_statx_flags(char *bf, size_t size, struct syscall_
P_FLAG(SYMLINK_FOLLOW);
P_FLAG(NO_AUTOMOUNT);
P_FLAG(EMPTY_PATH);
+ P_FLAG(STATX_SYNC_AS_STAT);
P_FLAG(STATX_FORCE_SYNC);
P_FLAG(STATX_DONT_SYNC);
--
2.34.1
next prev parent reply other threads:[~2024-04-18 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:13 [PATCH 0/4] perf trace beauty: A fix and some improvements for newfstatat,mprotect Changbin Du
2024-04-18 13:13 ` [PATCH 1/4] perf trace beauty: Fix statx flags printing Changbin Du
2024-04-18 14:35 ` Arnaldo Carvalho de Melo
2024-04-19 1:38 ` duchangbin
2024-04-19 3:45 ` duchangbin
2024-04-18 13:13 ` Changbin Du [this message]
2024-04-18 13:13 ` [PATCH 3/4] perf trace beauty: Always show param if show_zero is set Changbin Du
2024-04-18 13:13 ` [PATCH 4/4] perf trace beauty: Always show mprotect prot even though PROT_NONE Changbin Du
2024-04-18 14:31 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418131304.3188385-3-changbin.du@huawei.com \
--to=changbin.du@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®