From: Josua Mayer <josua@solid-run.com>
To: Michael Hennerich <michael.hennerich@analog.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandru Tachici <alexandru.tachici@analog.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: Jon Nettleton <jon@solid-run.com>,
Yazan Shhady <yazan.shhady@solid-run.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Josua Mayer <josua@solid-run.com>
Subject: [PATCH net-next 2/2] net: phy: adin: add support for setting led-, link-status-pin polarity
Date: Fri, 19 Apr 2024 17:35:18 +0200 [thread overview]
Message-ID: <20240419-adin-pin-polarity-v1-2-eaae8708db8d@solid-run.com> (raw)
In-Reply-To: <20240419-adin-pin-polarity-v1-0-eaae8708db8d@solid-run.com>
ADIN1300 supports software control over pin polarity for both LED_0 and
LINK_ST pins.
Configure the polarity during probe based on device-tree properties.
Led polarity is only set if specified in device-tree, otherwise the phy
can choose either active-low or active-high based on external line
voltage. Link-status polarity is set to active-high as default if not
specified, which is always the reset-default.
Signed-off-by: Josua Mayer <josua@solid-run.com>
---
drivers/net/phy/adin.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
index 2e1a46e121d9..53159dea6381 100644
--- a/drivers/net/phy/adin.c
+++ b/drivers/net/phy/adin.c
@@ -114,6 +114,9 @@
#define ADIN1300_CDIAG_FLT_DIST(x) (0xba21 + (x))
+#define ADIN1300_LED_A_INV_EN_REG 0xbc01
+#define ADIN1300_LED_A_INV_EN BIT(0)
+
#define ADIN1300_GE_SOFT_RESET_REG 0xff0c
#define ADIN1300_GE_SOFT_RESET BIT(0)
@@ -158,6 +161,9 @@
#define ADIN1300_RMII_20_BITS 0x0004
#define ADIN1300_RMII_24_BITS 0x0005
+#define ADIN1300_GE_LNK_STAT_INV_EN_REG 0xff3c
+#define ADIN1300_GE_LNK_STAT_INV_EN BIT(0)
+
/**
* struct adin_cfg_reg_map - map a config value to aregister value
* @cfg: value in device configuration
@@ -522,6 +528,49 @@ static int adin_config_clk_out(struct phy_device *phydev)
ADIN1300_GE_CLK_CFG_MASK, sel);
}
+static int adin_config_pin_polarity(struct phy_device *phydev)
+{
+ struct device *dev = &phydev->mdio.dev;
+ int ret;
+ u32 val;
+
+ /* set led polarity, if property present */
+ if (device_property_present(dev, "adi,led-polarity")) {
+ ret = device_property_read_u32(dev, "adi,led-polarity", &val);
+ if (ret) {
+ return ret;
+ } else if (val > 1) {
+ phydev_err(phydev, "invalid adi,led-polarity\n");
+ return -EINVAL;
+ }
+
+ ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+ ADIN1300_LED_A_INV_EN_REG,
+ ADIN1300_LED_A_INV_EN, val);
+ if (ret)
+ return ret;
+ }
+
+ /* set link-status polarity, default to active-high (0) */
+ if (device_property_present(dev, "adi,link-st-polarity")) {
+ ret = device_property_read_u32(dev, "adi,link-st-polarity", &val);
+ if (ret) {
+ return ret;
+ } else if (val > 1) {
+ phydev_err(phydev, "invalid adi,link-st-polarity\n");
+ return -EINVAL;
+ }
+ } else {
+ val = 0;
+ }
+
+ ret = phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+ ADIN1300_GE_LNK_STAT_INV_EN_REG,
+ ADIN1300_GE_LNK_STAT_INV_EN, val);
+
+ return ret;
+}
+
static int adin_config_init(struct phy_device *phydev)
{
int rc;
@@ -548,6 +597,10 @@ static int adin_config_init(struct phy_device *phydev)
if (rc < 0)
return rc;
+ rc = adin_config_pin_polarity(phydev);
+ if (rc < 0)
+ return rc;
+
phydev_dbg(phydev, "PHY is using mode '%s'\n",
phy_modes(phydev->interface));
--
2.35.3
next prev parent reply other threads:[~2024-04-19 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 15:35 [PATCH net-next 0/2] " Josua Mayer
2024-04-19 15:35 ` [PATCH net-next 1/2] dt-bindings: net: adin: add pin polarity properties for LED_0, LINK_ST Josua Mayer
2024-04-19 15:35 ` Josua Mayer [this message]
2024-04-19 15:47 ` [PATCH net-next 2/2] net: phy: adin: add support for setting led-, link-status-pin polarity Andrew Lunn
2024-04-20 9:10 ` Josua Mayer
2024-04-20 16:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419-adin-pin-polarity-v1-2-eaae8708db8d@solid-run.com \
--to=josua@solid-run.com \
--cc=alexandru.tachici@analog.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jon@solid-run.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®