mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH 02/10] platform/x86/intel/tpmi: Check major version change for TPMI Information
Date: Tue, 23 Apr 2024 13:46:11 -0700	[thread overview]
Message-ID: <20240423204619.3946901-3-srinivas.pandruvada@linux.intel.com> (raw)
In-Reply-To: <20240423204619.3946901-1-srinivas.pandruvada@linux.intel.com>

Check the major version from TPMI information header and fail to load
driver if the version is not supported.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/platform/x86/intel/tpmi.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/intel/tpmi.c b/drivers/platform/x86/intel/tpmi.c
index 003e765dedea..a5bcb77bcb35 100644
--- a/drivers/platform/x86/intel/tpmi.c
+++ b/drivers/platform/x86/intel/tpmi.c
@@ -666,28 +666,37 @@ static int tpmi_create_devices(struct intel_tpmi_info *tpmi_info)
 }
 
 #define TPMI_INFO_BUS_INFO_OFFSET	0x08
+#define TPMI_INFO_MAJOR_VERSION		0x00
 
 static int tpmi_process_info(struct intel_tpmi_info *tpmi_info,
 			     struct intel_tpmi_pm_feature *pfs)
 {
 	struct tpmi_info_header header;
 	void __iomem *info_mem;
+	u64 feature_header;
+	int ret = 0;
 
-	info_mem = ioremap(pfs->vsec_offset + TPMI_INFO_BUS_INFO_OFFSET,
-			   pfs->pfs_header.entry_size * sizeof(u32) - TPMI_INFO_BUS_INFO_OFFSET);
+	info_mem = ioremap(pfs->vsec_offset, pfs->pfs_header.entry_size * sizeof(u32));
 	if (!info_mem)
 		return -ENOMEM;
 
-	memcpy_fromio(&header, info_mem, sizeof(header));
+	feature_header = readq(info_mem);
+	if (TPMI_MAJOR_VERSION(feature_header) != TPMI_INFO_MAJOR_VERSION) {
+		ret = -ENODEV;
+		goto error_info_header;
+	}
+
+	memcpy_fromio(&header, info_mem + TPMI_INFO_BUS_INFO_OFFSET, sizeof(header));
 
 	tpmi_info->plat_info.package_id = header.pkg;
 	tpmi_info->plat_info.bus_number = header.bus;
 	tpmi_info->plat_info.device_number = header.dev;
 	tpmi_info->plat_info.function_number = header.fn;
 
+error_info_header:
 	iounmap(info_mem);
 
-	return 0;
+	return ret;
 }
 
 static int tpmi_fetch_pfs_header(struct intel_tpmi_pm_feature *pfs, u64 start, int size)
-- 
2.40.1


  parent reply	other threads:[~2024-04-23 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 20:46 [PATCH 00/10] Support partitioned systems Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 01/10] platform/x86/intel/tpmi: Handle error from tpmi_process_info() Srinivas Pandruvada
2024-04-23 20:46 ` Srinivas Pandruvada [this message]
2024-04-23 20:46 ` [PATCH 03/10] platform/x86/intel/tpmi: Align comments in kernel-doc Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 04/10] platform/x86/intel/tpmi: Add additional TPMI header fields Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 05/10] platform/x86: ISST: Use local variable for auxdev->dev Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 06/10] platform/x86: ISST: Shorten the assignments for power_domain_info Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 07/10] platform/x86: ISST: Support partitioned systems Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 08/10] platform/x86: ISST: Use in_range() to check package ID validity Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 09/10] platform/x86: ISST: Add dev_fmt Srinivas Pandruvada
2024-04-23 20:46 ` [PATCH 10/10] platform/x86: ISST: Add missing MODULE_DESCRIPTION Srinivas Pandruvada
2024-04-29 11:03 ` [PATCH 00/10] Support partitioned systems Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423204619.3946901-3-srinivas.pandruvada@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®