From: Borislav Petkov <bp@alien8.de>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
viresh.kumar@linaro.org, Ray.Huang@amd.com,
gautham.shenoy@amd.com, Alexander.Deucher@amd.com,
Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/6] cpufreq: amd-pstate: initialize new core precision boost state
Date: Fri, 26 Apr 2024 12:34:47 +0200 [thread overview]
Message-ID: <20240426103447.GAZiuDR7u2d-AXspik@fat_crate.local> (raw)
In-Reply-To: <6ea9dc722218a8498e60612cdcd26e99305c16a8.1714112854.git.perry.yuan@amd.com>
On Fri, Apr 26, 2024 at 02:34:45PM +0800, Perry Yuan wrote:
> @@ -665,18 +667,31 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> return 0;
> }
>
> -static void amd_pstate_boost_init(struct amd_cpudata *cpudata)
> +static int amd_pstate_boost_init(struct amd_cpudata *cpudata)
> {
> - u32 highest_perf, nominal_perf;
> + u64 boost_val;
> + int ret;
>
> - highest_perf = READ_ONCE(cpudata->highest_perf);
> - nominal_perf = READ_ONCE(cpudata->nominal_perf);
> + if (!boot_cpu_has(X86_FEATURE_CPB)) {
Repeat after me:
Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()!
Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()!
Everytime I need to test a X86_FEATURE flag, I will use cpu_feature_enabled()!
Everytime I need to test a X86_FEATURE flag, I ...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-04-26 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 6:34 [PATCH v8 0/6] AMD Pstate Driver Core Performance Boost Perry Yuan
2024-04-26 6:34 ` [PATCH v8 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h Perry Yuan
2024-04-26 6:34 ` [PATCH v8 2/6] cpufreq: amd-pstate: initialize new core precision boost state Perry Yuan
2024-04-26 10:34 ` Borislav Petkov [this message]
2024-04-26 6:34 ` [PATCH v8 3/6] cpufreq: amd-pstate: implement cpb_boost sysfs entry for boost control Perry Yuan
2024-04-26 14:07 ` Mario Limonciello
2024-04-27 20:24 ` Mario Limonciello
2024-04-26 6:34 ` [PATCH v8 4/6] cpufreq: amd-pstate: fix the MSR highest perf will be reset issue while cpb boost off Perry Yuan
2024-04-26 14:11 ` Mario Limonciello
2024-04-26 6:34 ` [PATCH v8 5/6] Documentation: cpufreq: amd-pstate: introduce the new cpu boost control method Perry Yuan
2024-04-26 14:10 ` Mario Limonciello
2024-04-26 6:34 ` [PATCH v8 6/6] cpufreq: amd-pstate-ut: support new cpb boost control interface Perry Yuan
2024-04-26 14:13 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426103447.GAZiuDR7u2d-AXspik@fat_crate.local \
--to=bp@alien8.de \
--cc=Alexander.Deucher@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®