From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F7031A81; Sun, 28 Apr 2024 17:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714325201; cv=none; b=ArGAAhK+u/W4fvThMqGiVdAxdRccKhCQl529PiTK7Qj0RghyvEt9pKcs27xUnxVZL65hlZqmmUz/gu5546ZNiXf45M2IwwTTmJ9ym/IsQDQvkdOjuC6W4ixTLa5oIGTjvJXxNNHMYie6gtFky2UJir7iKBguGUO3MOsVuIIVINc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714325201; c=relaxed/simple; bh=JEvW1NTvAodacPcdsV+8rSNHzXnu7DiMn8JDRUV0KUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CYHanlpgp/sVhseRfxbQ5LP0frRuw4BfVqh6q6KnFuONmYR3eAafItZTwWqOKcixxvPDGCKM+FcskmtbRkpC7LqKGwe+LRKqWvSL1aWSyns+kQbPdOT9YgbcyF2N+jdr46XqsedANajZqG46xCXOVk1Xsd9xxdvWhe4PPBDuQi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=RUQiBFDe; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="RUQiBFDe" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 7CF0B40E0187; Sun, 28 Apr 2024 17:26:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id DS8HxuSXsenB; Sun, 28 Apr 2024 17:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1714325191; bh=AF8W5OpNeob6gkJBdYGpZUOpvF721UDovoNC7CvPOHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RUQiBFDe6dDNPHrCSly4pEgY8TtrM8DbCwhUr+mxNl3Lm8ocQxCYt9/mYcR5YHQx2 uvweoaTlWfeD3iIEAGsvWR2pBXOfQczb237pnxPwBSHT/PkDiQUxSvbHgdKEoIa/wN q3k3VxIhmUboThxtYAcJCh9gBqStlMXe/EdEX5THho6000MBHxZhGBt5nJu8KNFAC1 UY+VEWkQeMVJBvujL8td3illvcSw81wjz+5DUM/YgtnzVLUT6Usrbd+ljDGCY3Kvi1 QBx/KCEFBHMsBGVUM36n9UbNV9/ToBMGVMvw977DDG/Ld+ZMP4uqATXfVv3Oo0VzwT IYmsFSkyMgqFVcg2xgPYM7lx6+2FD+Ia7RARnO/uqb+jlr75G904vEHbY23Y68AG+o KdCtX3Pb74t+ofbOFnPuLLdNss/oYGrDuDZyNGqd5EaXz4zMWRLThSnhxMHVdkZzvE ZYuPSB6VnJteiNT4QE2RtrMmsgDVFtaatl2Bxv9+Ir9wTbg5C2i+uwLkOzZdEH5oFJ 5fvE/YWQ1BMsRycDcbKcBFhhd9j7VobrUTkvEX551lrDD+q4k4aa820sX2I6AvuT1K Dab7a/zyCk+Oh5NJIPuAdehS3vflkdDSg7Q0OWkuklZ1LFSxOrPEMeuCPuD2mdTo0W azDtrM/cYn0ny3rwBRhZb0k8= Received: from zn.tnic (pd953020b.dip0.t-ipconnect.de [217.83.2.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 28CB040E0205; Sun, 28 Apr 2024 17:26:04 +0000 (UTC) Date: Sun, 28 Apr 2024 19:25:57 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , Adrian Hunter , Kuppuswamy Sathyanarayanan , Elena Reshetova , Jun Nakajima , Rick Edgecombe , Tom Lendacky , "Kalra, Ashish" , Sean Christopherson , "Huang, Kai" , Baoquan He , kexec@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Dave Hansen , Tao Liu , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , linux-hyperv@vger.kernel.org Subject: Re: [PATCHv10 06/18] x86/mm: Make x86_platform.guest.enc_status_change_*() return errno Message-ID: <20240428172557.GLZi6GpTaSBj-DphCL@fat_crate.local> References: <20240409113010.465412-1-kirill.shutemov@linux.intel.com> <20240409113010.465412-7-kirill.shutemov@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240409113010.465412-7-kirill.shutemov@linux.intel.com> On Tue, Apr 09, 2024 at 02:29:58PM +0300, Kirill A. Shutemov wrote: > TDX is going to have more than one reason to fail > enc_status_change_prepare(). > > Change the callback to return errno instead of assuming -EIO; > enc_status_change_finish() changed too to keep the interface symmetric. "Change enc_status_change_finish() too... " "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." You should know this by now... > Signed-off-by: Kirill A. Shutemov > Reviewed-by: Dave Hansen > Reviewed-by: Kai Huang > Tested-by: Tao Liu > --- > arch/x86/coco/tdx/tdx.c | 20 +++++++++++--------- > arch/x86/hyperv/ivm.c | 22 ++++++++++------------ > arch/x86/include/asm/x86_init.h | 4 ++-- > arch/x86/kernel/x86_init.c | 4 ++-- > arch/x86/mm/mem_encrypt_amd.c | 8 ++++---- > arch/x86/mm/pat/set_memory.c | 8 +++++--- > 6 files changed, 34 insertions(+), 32 deletions(-) Another thing you should long know by now: get_maintainer.pl. You do know that when you send a patch which touches multiple different "places", you run it through get_maintainer.pl to get some hints as to who to CC, right? Because you're touching HyperV code and yet none of the HyperV folks are CCed. Do I need to give you the spiel I give to kernel newbies? :) Lemme Cc them for you now. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette