From: Maxime Ripard <mripard@kernel.org>
To: Sui Jingfeng <suijingfeng@bosc.ac.cn>
Cc: Sui Jingfeng <sui.jingfeng@linux.dev>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Douglas Anderson <dianders@chromium.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: drm/debugfs: Drop conditionals around of_node pointers
Date: Mon, 29 Apr 2024 13:30:24 +0200 [thread overview]
Message-ID: <20240429-enchanted-cooperative-jacamar-cf2902@houat> (raw)
In-Reply-To: <caa6fb05-8080-444a-93c3-2d9283ccb74d@bosc.ac.cn>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Sun, Apr 28, 2024 at 04:52:13PM +0800, Sui Jingfeng wrote:
> ping
>
> 在 2024/3/22 06:22, Sui Jingfeng 写道:
> > Having conditional around the of_node pointer of the drm_bridge structure
> > turns out to make driver code use ugly #ifdef blocks.
The code being ugly is an opinion, what problem is it causing exactly?
> Drop the conditionals to simplify debugfs.
What does it simplifies?
> >
> > Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers")
> > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Why do we want to backport that patch to stable?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2024-04-29 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 22:22 [PATCH] " Sui Jingfeng
2024-04-28 8:52 ` Sui Jingfeng
2024-04-29 11:30 ` Maxime Ripard [this message]
2024-04-30 1:15 ` 隋景峰
2024-04-30 21:33 ` Doug Anderson
2024-05-01 4:36 ` Sui Jingfeng
2024-04-29 11:20 ` [PATCH] " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429-enchanted-cooperative-jacamar-cf2902@houat \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=sui.jingfeng@linux.dev \
--cc=suijingfeng@bosc.ac.cn \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®