mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>
Cc: <linux-wireless@vger.kernel.org>, <ath11k@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: [PATCH 0/2] wifi: ath11k: fix ioremap() leak
Date: Tue, 30 Apr 2024 06:30:19 -0700	[thread overview]
Message-ID: <20240430-ce-unmap-v1-0-e468328f95d9@quicinc.com> (raw)

smatch flagged the following issue:

drivers/net/wireless/ath/ath11k/ahb.c:1218 ath11k_ahb_probe() warn: 'ab->mem_ce' from ioremap() not released on lines: 1218.

Fix it by refactoring the ioremap and iounmap code and then calling the
unmap in the ath11k_ahb_probe() error path.

---
Jeff Johnson (2):
      wifi: ath11k: refactor CE remap & unmap
      wifi: ath11k: unmap the CE in ath11k_ahb_probe() error path

 drivers/net/wireless/ath/ath11k/ahb.c | 57 +++++++++++++++++++++++------------
 1 file changed, 38 insertions(+), 19 deletions(-)
---
base-commit: bf99bc7423e18aa3475ef00a7a6fb773c31ce6df
change-id: 20240427-ce-unmap-3030e38ba1bb


             reply	other threads:[~2024-04-30 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 13:30 Jeff Johnson [this message]
2024-04-30 13:30 ` [PATCH 1/2] wifi: ath11k: refactor CE remap & unmap Jeff Johnson
2024-05-03 13:15   ` Kalle Valo
2024-04-30 13:30 ` [PATCH 2/2] wifi: ath11k: unmap the CE in ath11k_ahb_probe() error path Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430-ce-unmap-v1-0-e468328f95d9@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=ath11k@lists.infradead.org \
    --cc=jjohnson@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®