mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] crypto: passing configuration parameters to comp algos
Date: Mon, 29 Apr 2024 20:18:47 -0700	[thread overview]
Message-ID: <20240430031847.GB10165@sol.localdomain> (raw)
In-Reply-To: <20240430030447.GE14947@google.com>

On Tue, Apr 30, 2024 at 12:04:47PM +0900, Sergey Senozhatsky wrote:
> Hi,
> 
> 	We'd like to be able to pass algorithm-specific parameters to
> comp backends. As of this moment, crypto usees hard-coded default
> values and does not permit any run-time algorithm configuration,
> which in some cases simply disables the most interesting functionality.
> E.g. zstd can be configured to use a pre-trained (in the user-space)
> compression dictionary, which significantly changes algorithms
> characteristics. Another, obvious and trivial example, is algorithms
> compression level.
> 
> The problem is that we need to pass params to cra_init() function,
> because for some algorithms that's the only place where configuration
> can take place (e.g. zstd). Changing cra_init() to accept additional
> `struct crypto_comp_params` looks to be a little intrusive so before
> I write any patches I'd like to hear your thoughts.
> 

Have you considered just using the zstd library (<linux/zstd.h>) directly?

Which kernel subsystem are you working on that uses compression?

- Eric

  reply	other threads:[~2024-04-30  3:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  3:04 Sergey Senozhatsky
2024-04-30  3:18 ` Eric Biggers [this message]
2024-04-30  3:28   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430031847.GB10165@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®