From: Mike Tipton <quic_mdtipton@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Georgi Djakov <djakov@kernel.org>,
Shawn Guo <shawn.guo@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
<quic_okukatla@quicinc.com>
Subject: Re: [PATCH 4/4] interconnect: qcom: icc-rpm: Remodel how QoS settings are stored
Date: Tue, 7 May 2024 18:45:30 -0700 [thread overview]
Message-ID: <20240508014530.GB25316@hu-mdtipton-lv.qualcomm.com> (raw)
In-Reply-To: <20240326-topic-rpm_icc_qos_cleanup-v1-4-357e736792be@linaro.org>
Hi Konrad,
On Tue, Mar 26, 2024 at 08:42:35PM +0100, Konrad Dybcio wrote:
> Currently, the QoS settings are stored in the node data, even though
> they're a property of the bus/provider instead. Moreover, they are only
> needed during the probe step, so they can be easily moved into struct
> qcom_icc_desc.
The QoS settings *are* fundamentally a property of the node. The nodes
are 1:1 with the NOC ports. And the QoS settings tune the priority of
the data coming out of those ports. So, logically speaking, the QoS data
does belong in the node structs along with the rest of the data for that
node and port.
Only a subset of NOC ports support configurable QoS, but for those ports
that do it's a property of the port itself. Those settings impact just
that specific port and nothing else.
The current method of directly embedding the qcom_icc_qos_data struct
into qcom_icc_node isn't optimal, since that data is irrelevant for
ports that don't support it. So, the size could be optimized by
converting qcom_icc_node::qos into a pointer instead. But I don't think
we should separate the QoS settings from node struct entirely. It makes
it very difficult to understand which QoS settings are impacting which
port.
For example...
>
> diff --git a/drivers/interconnect/qcom/msm8996.c b/drivers/interconnect/qcom/msm8996.c
> index 788131400cd1..96c8ea8edd7a 100644
> --- a/drivers/interconnect/qcom/msm8996.c
> +++ b/drivers/interconnect/qcom/msm8996.c
> @@ -43,11 +43,7 @@ static struct qcom_icc_node mas_pcie_0 = {
> .buswidth = 8,
> .mas_rpm_id = 65,
> .slv_rpm_id = -1,
> - .qos.ap_owned = true,
> - .qos.qos_mode = NOC_QOS_MODE_FIXED,
> - .qos.areq_prio = 1,
> - .qos.prio_level = 1,
> - .qos.qos_port = 0,
> + .ap_owned = true,
> .num_links = ARRAY_SIZE(mas_a0noc_common_links),
> .links = mas_a0noc_common_links
> };
[...]
>
> +static const struct qcom_icc_qos_data a0noc_qos_data[] = {
> + {
> + .qos_port = 0,
> + .qos_mode = NOC_QOS_MODE_FIXED,
> + .areq_prio = 1,
> + .prio_level = 1,
> + .urg_fwd_en = false,
> + .limit_commands = false,
> + }, {
How can I tell that these a0noc_qos_data[0] settings are for the
mas_pcie_0 port? It's not possible from the code anymore. *We* could
figure it out internally by looking at the NOC SWI to determine the
qos_port index. But this should be obvious from the code itself.
> + .qos_port = 1,
> + .qos_mode = NOC_QOS_MODE_FIXED,
> + .areq_prio = 1,
> + .prio_level = 1,
> + .urg_fwd_en = false,
> + .limit_commands = false,
> + }, {
> + .qos_port = 2,
> + .qos_mode = NOC_QOS_MODE_FIXED,
> + .areq_prio = 1,
> + .prio_level = 1,
> + .urg_fwd_en = false,
> + .limit_commands = false,
> + },
> +};
> +
next prev parent reply other threads:[~2024-05-08 1:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 19:42 [PATCH 0/4] Rework rpm-icc QoS settings Konrad Dybcio
2024-03-26 19:42 ` [PATCH 1/4] interconnect: qcom: sm6115: Unspaghettify SNoC QoS port numbering Konrad Dybcio
2024-03-26 20:13 ` Dmitry Baryshkov
2024-03-26 20:32 ` Konrad Dybcio
2024-03-26 19:42 ` [PATCH 2/4] interconnect: qcom: qcm2290: Fix mas_snoc_bimc QoS port assignment Konrad Dybcio
2024-03-26 20:16 ` Stephan Gerhold
2024-03-26 21:32 ` Konrad Dybcio
2024-03-26 19:42 ` [PATCH 3/4] interconnect: qcom: icc-rpm: Make simple functions return void Konrad Dybcio
2024-03-26 20:14 ` Dmitry Baryshkov
2024-05-08 1:57 ` Mike Tipton
2024-03-26 19:42 ` [PATCH 4/4] interconnect: qcom: icc-rpm: Remodel how QoS settings are stored Konrad Dybcio
2024-03-26 20:57 ` Stephan Gerhold
2024-03-26 21:12 ` Konrad Dybcio
2024-05-08 1:45 ` Mike Tipton [this message]
2024-06-18 14:27 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508014530.GB25316@hu-mdtipton-lv.qualcomm.com \
--to=quic_mdtipton@quicinc.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_okukatla@quicinc.com \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®