From: Ravi Bangoria <ravi.bangoria@amd.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<namhyung@kernel.org>, <irogers@google.com>
Cc: <ravi.bangoria@amd.com>, <swapnil.sapkal@amd.com>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <rostedt@goodmis.org>,
<vincent.guittot@linaro.org>, <bristot@redhat.com>,
<adrian.hunter@intel.com>, <james.clark@arm.com>,
<kan.liang@linux.intel.com>, <gautham.shenoy@amd.com>,
<kprateek.nayak@amd.com>, <juri.lelli@redhat.com>,
<yangjihong@bytedance.com>, <linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>, <santosh.shukla@amd.com>,
<ananth.narayan@amd.com>, <sandipan.das@amd.com>
Subject: [RFC 2/4] perf sched: Add template code for schedstat subcommand
Date: Wed, 8 May 2024 11:34:25 +0530 [thread overview]
Message-ID: <20240508060427.417-3-ravi.bangoria@amd.com> (raw)
In-Reply-To: <20240508060427.417-1-ravi.bangoria@amd.com>
perf sched schedstat will allow user to record the profile with `record`
subcommand and analyse it with `report` subcommand.
Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
---
tools/perf/builtin-sched.c | 48 +++++++++++++++++++++++++++++++++++++-
1 file changed, 47 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index bc1317d7e106..717bdf113241 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -3504,6 +3504,21 @@ static int __cmd_record(int argc, const char **argv)
return ret;
}
+/* perf.data or any other output file name used by schedstat subcommand (only). */
+const char *output_name;
+
+static int perf_sched__schedstat_record(struct perf_sched *sched __maybe_unused,
+ int argc __maybe_unused,
+ const char **argv __maybe_unused)
+{
+ return 0;
+}
+
+static int perf_sched__schedstat_report(struct perf_sched *sched __maybe_unused)
+{
+ return 0;
+}
+
static const char default_sort_order[] = "avg, max, switch, runtime";
static struct perf_sched perf_sched = {
.tool = {
@@ -3593,6 +3608,13 @@ int cmd_sched(int argc, const char **argv)
OPT_STRING('C', "cpu", &cpu_list, "cpu", "list of cpus to profile"),
OPT_PARENT(sched_options)
};
+ const struct option schedstat_options[] = {
+ OPT_STRING('i', "input", &input_name, "file",
+ "`schedstat report` with input filename"),
+ OPT_STRING('o', "output", &output_name, "file",
+ "`schedstat record` with output filename"),
+ OPT_END()
+ };
const char * const latency_usage[] = {
"perf sched latency [<options>]",
@@ -3610,9 +3632,13 @@ int cmd_sched(int argc, const char **argv)
"perf sched timehist [<options>]",
NULL
};
+ const char *schedstat_usage[] = {
+ "perf sched schedstat {record|report} [<options>]",
+ NULL
+ };
const char *const sched_subcommands[] = { "record", "latency", "map",
"replay", "script",
- "timehist", NULL };
+ "timehist", "schedstat", NULL };
const char *sched_usage[] = {
NULL,
NULL
@@ -3693,6 +3719,26 @@ int cmd_sched(int argc, const char **argv)
return ret;
return perf_sched__timehist(&perf_sched);
+ } else if (!strcmp(argv[0], "schedstat")) {
+ const char *const schedstat_subcommands[] = {"record", "report", NULL};
+
+ argc = parse_options_subcommand(argc, argv, schedstat_options,
+ schedstat_subcommands,
+ schedstat_usage, 0);
+
+ if (argv[0] && !strcmp(argv[0], "record")) {
+ if (argc)
+ argc = parse_options(argc, argv, schedstat_options,
+ schedstat_usage, 0);
+ ret = perf_sched__schedstat_record(&perf_sched, argc, argv);
+ } else if (argv[0] && !strcmp(argv[0], "report")) {
+ if (argc)
+ argc = parse_options(argc, argv, schedstat_options,
+ schedstat_usage, 0);
+ ret = perf_sched__schedstat_report(&perf_sched);
+ } else {
+ usage_with_options(schedstat_usage, schedstat_options);
+ }
} else {
usage_with_options(sched_usage, sched_options);
}
--
2.44.0
next prev parent reply other threads:[~2024-05-08 6:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 6:04 [RFC 0/4] perf sched: Introduce schedstat tool Ravi Bangoria
2024-05-08 6:04 ` [RFC 1/4] perf sched: Make `struct perf_sched sched` a global variable Ravi Bangoria
2024-05-08 6:04 ` Ravi Bangoria [this message]
2024-05-08 6:04 ` [RFC 3/4] perf sched schedstat: Add record and rawdump support Ravi Bangoria
2024-05-08 6:04 ` [RFC 4/4] perf sched schedstat: Add support for report subcommand Ravi Bangoria
2024-05-11 7:45 ` Chen Yu
2024-05-13 3:13 ` Ravi Bangoria
2024-05-08 22:21 ` [RFC 0/4] perf sched: Introduce schedstat tool Ian Rogers
2024-05-09 5:09 ` Ravi Bangoria
2024-05-09 5:08 ` Namhyung Kim
2024-05-09 6:02 ` Ravi Bangoria
2024-05-09 22:33 ` Namhyung Kim
2024-05-10 4:46 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508060427.417-3-ravi.bangoria@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bristot@redhat.com \
--cc=gautham.shenoy@amd.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=swapnil.sapkal@amd.com \
--cc=vincent.guittot@linaro.org \
--cc=yangjihong@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®