mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v1 08/10] misc: eeprom_93xx46: Replace explicit castings with proper specifiers
Date: Wed,  8 May 2024 21:47:01 +0300	[thread overview]
Message-ID: <20240508184905.2102633-9-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240508184905.2102633-1-andriy.shevchenko@linux.intel.com>

There is no need to have an explicit casting when we can simply use
the correct printf() specifier.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/misc/eeprom/eeprom_93xx46.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
index 18a3b534ea73..ac485b2827db 100644
--- a/drivers/misc/eeprom/eeprom_93xx46.c
+++ b/drivers/misc/eeprom/eeprom_93xx46.c
@@ -162,8 +162,8 @@ static int eeprom_93xx46_read(void *priv, unsigned int off,
 		ndelay(250);
 
 		if (err) {
-			dev_err(&edev->spi->dev, "read %zu bytes at %d: err. %d\n",
-				nbytes, (int)off, err);
+			dev_err(&edev->spi->dev, "read %zu bytes at %u: err. %d\n",
+				nbytes, off, err);
 			break;
 		}
 
@@ -274,7 +274,8 @@ static int eeprom_93xx46_write(void *priv, unsigned int off,
 {
 	struct eeprom_93xx46_dev *edev = priv;
 	char *buf = val;
-	int i, ret, step = 1;
+	int ret, step = 1;
+	unsigned int i;
 
 	if (unlikely(off >= edev->size))
 		return -EFBIG;
@@ -301,8 +302,7 @@ static int eeprom_93xx46_write(void *priv, unsigned int off,
 	for (i = 0; i < count; i += step) {
 		ret = eeprom_93xx46_write_word(edev, &buf[i], off + i);
 		if (ret) {
-			dev_err(&edev->spi->dev, "write failed at %d: %d\n",
-				(int)off + i, ret);
+			dev_err(&edev->spi->dev, "write failed at %u: %d\n", off + i, ret);
 			break;
 		}
 	}
-- 
2.43.0.rc1.1336.g36b5255a03ac


  parent reply	other threads:[~2024-05-08 18:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 18:46 [PATCH v1 00/10] misc: eeprom_93xx46: Get rid of legacy GPIO APIs Andy Shevchenko
2024-05-08 18:46 ` [PATCH v1 01/10] misc: eeprom_93xx46: Make use of device properties Andy Shevchenko
2024-05-27 13:21   ` Linus Walleij
2024-05-08 18:46 ` [PATCH v1 02/10] eeprom: digsy_mtc: Fix 93xx46 driver probe failure Andy Shevchenko
2024-05-08 18:46 ` [PATCH v1 03/10] eeprom: digsy_mtc: Convert to use GPIO descriptors Andy Shevchenko
2024-05-27 13:24   ` Linus Walleij
2024-05-08 18:46 ` [PATCH v1 04/10] misc: eeprom_93xx46: Hide legacy platform data in the driver Andy Shevchenko
2024-05-27 13:24   ` Linus Walleij
2024-05-08 18:46 ` [PATCH v1 05/10] misc: eeprom_93xx46: Remove ->prepare() and ->finish() customisation Andy Shevchenko
2024-05-27 13:25   ` Linus Walleij
2024-05-08 18:46 ` [PATCH v1 06/10] misc: eeprom_93xx46: Use spi_message_init_with_transfers() Andy Shevchenko
2024-05-08 18:47 ` [PATCH v1 07/10] misc: eeprom_93xx46: Convert to use kstrtox() Andy Shevchenko
2024-05-27 13:26   ` Linus Walleij
2024-05-08 18:47 ` Andy Shevchenko [this message]
2024-05-27 13:29   ` [PATCH v1 08/10] misc: eeprom_93xx46: Replace explicit castings with proper specifiers Linus Walleij
2024-05-08 18:47 ` [PATCH v1 09/10] misc: eeprom_93xx46: Use string_choices API instead of ternary operator Andy Shevchenko
2024-05-27 13:30   ` Linus Walleij
2024-05-08 18:47 ` [PATCH v1 10/10] misc: eeprom_93xx46: Convert to DEVICE_ATTR_WO() Andy Shevchenko
2024-05-27 13:31   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508184905.2102633-9-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®