From: Conor Dooley <conor@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Song Liu" <song@kernel.org>, "Xi Wang" <xi.wang@gmail.com>,
"Björn Töpel" <bjorn@rivosinc.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Jessica Clarke" <jrtc27@jrtc27.com>,
"Andy Chiu" <andy.chiu@sifive.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/8] riscv: Support compiling the kernel with more extensions
Date: Fri, 10 May 2024 09:35:49 +0100 [thread overview]
Message-ID: <20240510-pesky-tackling-1b715c4bce35@spud> (raw)
In-Reply-To: <20240510-okay-trade-8826cb134979@spud>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Fri, May 10, 2024 at 09:25:37AM +0100, Conor Dooley wrote:
> > > see why this particular optimisation was worth maintaining 3 code paths
> >
> > I interpreted the "3 code paths" as with Zbb + 64 bit, with Zbb + 32
> > bit, and without Zbb. I directly responded to that by saying that we
> > could eliminate all of the code paths that are not Zbb + 64 bit could be
> > eliminated.
Argh, forgot to say that that was what I meant by the 3 paths, but I
didn't take
| We could just say we don't care about performance if you are running
| 32-bit linux or don't have Zbb, but we would be making that decision
| because we don't feel like maintaining the code. The code was written,
| tested, reviewed, and it provided large performance gains. I fail to
| understand why this is a burden to maintain.
as seriously suggesting that we should remove anything, it read like a
defence of the current code!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-10 8:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 1:36 Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 1/8] riscv: Add PLATFORM_MAY_SUPPORT_RISCV_ISA_C Kconfig option Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 2/8] riscv: Add PLATFORM_MAY_SUPPORT_RISCV_ISA_V " Charlie Jenkins
2024-05-10 20:43 ` Conor Dooley
2024-05-10 21:43 ` Charlie Jenkins
2024-05-10 22:26 ` Conor Dooley
2024-05-15 14:34 ` Conor Dooley
2024-05-08 1:36 ` [PATCH v2 3/8] riscv: Add PLATFORM_SUPPORTS_RISCV_ISA_SVNAPOT " Charlie Jenkins
2024-05-08 9:00 ` Ben Dooks
2024-05-08 17:05 ` Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 4/8] riscv: Move RISCV_ISA_SVPBMT to Kconfig.isa Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 5/8] riscv: Add PLATFORM_SUPPORTS_RISCV_ISA_ZBB Kconfig option Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 6/8] riscv: Add PLATFORM_SUPPORTS_RISCV_ISA_ZBA " Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 7/8] riscv: Add PLATFORM_SUPPORTS_RISCV_ISA_ZBC " Charlie Jenkins
2024-05-08 1:36 ` [PATCH v2 8/8] riscv: Add PLATFORM_SUPPORTS_RISCV_ISA_ZBS " Charlie Jenkins
2024-05-09 20:25 ` [PATCH v2 0/8] riscv: Support compiling the kernel with more extensions Conor Dooley
2024-05-09 21:16 ` Charlie Jenkins
2024-05-09 22:08 ` Conor Dooley
2024-05-09 22:55 ` Charlie Jenkins
2024-05-10 8:25 ` Conor Dooley
2024-05-10 8:35 ` Conor Dooley [this message]
2024-05-10 16:48 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510-pesky-tackling-1b715c4bce35@spud \
--to=conor@kernel.org \
--cc=andy.chiu@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=bjorn@rivosinc.com \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=jrtc27@jrtc27.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=song@kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®