From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4870E53370 for ; Sat, 11 May 2024 12:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715429010; cv=none; b=egBXDVkiiEdAw59K6Mnu5+gTlRs75dOWfEnSJflX17l2vmxmC/hk/ptJoPdHUMxVrde784LLhiOd5qBXlVQDnPJRAW2RazSSPOB/3oQ/pN4SB0i8AVrgBm6o7DOG6jYnsB1VIQIO4VQ1MwkfT02ZtbFXSB3yc7ieV+EGL7QJP0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715429010; c=relaxed/simple; bh=4ei6JyB9sEad3jWzdL3h33UZe4MpMw6WQVfgiX7aMEY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r/slcvbdiAFSp93rJ9jmb9lEUmsO12L5fr38pbNViYDLzBvihOrDzxBMD/w4Mnh+wIeCras141KYj6FLlrfSYMk4BSLdkmCfZPvLG0RRLlpUmkfe6DgEYK5raHqVRogGRm6KMVdwlAnACv/ULo/EjbGvS7fqnWegxIK1Qc5EKfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J6fmmoPZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J6fmmoPZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 174B2C2BBFC; Sat, 11 May 2024 12:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715429009; bh=4ei6JyB9sEad3jWzdL3h33UZe4MpMw6WQVfgiX7aMEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J6fmmoPZEe/ReoNG8ROrbV1gTiyQxFLRF4zyINbbTCjuxwHhryTrWp+ilsGexw9SX 1RLch2qS27OWz+8WyZ3623TVHsQZOW3dUShB3YlMunxa8uWH7S+RelfyMqr0+0t96i n3WocTWRNC6suqD5MCHcwgCzSGWkmkDXL2xqzAYI= Date: Sat, 11 May 2024 12:59:23 +0100 From: Greg Kroah-Hartman To: Dominique Martinet Cc: cve@kernel.org, linux-kernel@vger.kernel.org Subject: Re: CVE-2022-48655: firmware: arm_scmi: Harden accesses to the reset domains Message-ID: <2024051148-fervor-aloft-43a3@gregkh> References: <2024042859-CVE-2022-48655-5feb@gregkh> <2024051041-resisting-chatroom-32c8@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 10, 2024 at 11:23:30PM +0900, Dominique Martinet wrote: > Greg Kroah-Hartman wrote on Fri, May 10, 2024 at 09:55:15AM +0100: > > > I can submit an edit as a patch to vulns.git json, but this doesn't seem > > > overly important so for now a mail will probably do. > > > > the json and mbox files are generated by tools, so patches to them is > > not a good idea as they will be overwritten the next time the scripts > > are run. > > Just let me know what's the most convenient; if mail it is I won't > bother :) > > > > >From a quick look it would seem it fixes arm_scmi from the addition of > > > scmi_domain_reset() in 95a15d80aa0d ("firmware: arm_scmi: Add RESET > > > protocol in SCMI v2.0"), which first appeared in v5.4-rc1, and does not > > > appear to have been backported to older kernels, so v5.4+ can be added > > > as a requirement. > > > > We can add a "this is where the problem showed up" if you know it, so > > that would be 95a15d80aa0d ("firmware: arm_scmi: Add RESET protocol in > > SCMI v2.0"), correct? > > Yes; this commit adds the out of bound access. Great, I'll mark the cve as having that as the "vulnerable" commit id, and then re-run the scripts and update the .json file and push it to cve.org when I get back to a better network connection. > > > This means the current 5.4/5.10 trees are affected; the commit doesn't > > > backport cleanly because of a trivial context conflict so if that helps > > > I can send a couple of stable patch if that helps even if our systems > > > are not using arm_scmi (CVEs also don't have any way of expressing > > > whether the affected driver is used (or even built) at all, so I guess > > > people with affected versions will have to check that themselves...) > > > > As everyone has different configurations, yes, everyone needs to check > > themselves, there is no way for us to determine this at all. But we do > > list the files affected, so that should help you out in determining this > > automatically on your end. > > I didn't see hte list of files anywhere for this, does it depend on the > commit? > (not that it's a problem to look at the commits referenced, I don't > think we'll automate anything for the forseeable future) Yes, it depeneds on the commit that fixes the issue, and the mail message for the CVE record says: The file(s) affected by this issue are: drivers/firmware/arm_scmi/reset.c Note that we can not include this in the json record format because, while cve has a field for this, it does not actually work properly for file names (it wants a url for a filename, strange but true...) This is a bug on the cve.org end and hopefully will be fixed one day so that we can provide the file name information in a machine-parsable format. > > And yes, backported patches would be always appreciated for older > > kernels if you have them. > > Sure, I'll take a min to finish the patches and send them on Monday; > might as well use work time when I've got an excuse to do kernel stuff. Wonderful, thanks! greg k-h