From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7E03233 for ; Sun, 12 May 2024 21:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715548568; cv=none; b=UKsULqA0l76P2ng/mktEJcGNf1her5/gQnt2iS24CahhGG5TM85rgKLBJ57681yS9n04Wj79wjs6wDgHeyhvSWniJU7bzHYd/daMYj+F2J5bri2m6NA0HLaug3nRnV92SPv8tPlprjMQEy6pRIxQHk910X6NG577DIHCL6GkpYw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715548568; c=relaxed/simple; bh=/VA+56EQcAeeuiXoZF5k8oky+wUSFnx62y8AokILwhA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ALKzflGHZlNUqi9VaQ/DkE2xsUUvmwjdce4qy7UHByh7tCJb4/1AViFxoZ/NreSqVghkSvczghHQacwHPVLFjHjFG055mhT8GGwAA/s0wUxWa3cqyGCSB/Lw/Y8GIe1nmQD91FsmoKKkv9W9yIR/c47cRzuHN2kv8WneRT8E5EA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=l4prDfu5; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="l4prDfu5" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F18B58BE; Sun, 12 May 2024 23:15:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1715548560; bh=/VA+56EQcAeeuiXoZF5k8oky+wUSFnx62y8AokILwhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l4prDfu5OchUlvmt+W/JmcSJhHpsGYBQrIPBxajPK649DhnzPCX2qalpn2B/HGm3k /1JlntQ04X/D5+xQQM8NupTKo3zUynlAeRRMosNEG8vAbtouwhHziGVIG+iwMPSUfT dyYfI5UXwcJkrsrkFyx5ohMZeZFleJfcZgtYZFHg= Date: Mon, 13 May 2024 00:15:58 +0300 From: Laurent Pinchart To: Sui Jingfeng Cc: Kieran Bingham , Biju Das , Alicja Michalska , Chen-Yu Tsai , Hsin-Yi Wang , Maxime Ripard , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: analogix: Remove redundant checks on existence of bridge->encoder Message-ID: <20240512211558.GN17158@pendragon.ideasonboard.com> References: <20240511152222.328167-1-sui.jingfeng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240511152222.328167-1-sui.jingfeng@linux.dev> Hi Sui, Thank you for the patch. On Sat, May 11, 2024 at 11:22:22PM +0800, Sui Jingfeng wrote: > The check on the existence of bridge->encoder on the implementation layer > of drm bridge driver is not necessary, as it has already been done in the > drm_bridge_attach() function. It is guaranteed that the .encoder member > of the drm_bridge instance is not NULL when various anxxxx_bridge_attach() > function gets called. And .atomic_enable() of struct drm_bridge_funcs > shouldn't be able to called before the various is acctached. > > Remove the redundant checking codes "if (!bridge->encoder) { ... }". > > Signed-off-by: Sui Jingfeng Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 5 ----- > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 5 ----- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 ----- > drivers/gpu/drm/bridge/analogix/anx7625.c | 10 ---------- > 4 files changed, 25 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > index c9e35731e6a1..cfe43d2ca3be 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c > @@ -528,11 +528,6 @@ static int anx6345_bridge_attach(struct drm_bridge *bridge, > return -EINVAL; > } > > - if (!bridge->encoder) { > - DRM_ERROR("Parent encoder object not found"); > - return -ENODEV; > - } > - > /* Register aux channel */ > anx6345->aux.name = "DP-AUX"; > anx6345->aux.dev = &anx6345->client->dev; > diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > index 5748a8581af4..58875dde496f 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > @@ -897,11 +897,6 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge, > return -EINVAL; > } > > - if (!bridge->encoder) { > - DRM_ERROR("Parent encoder object not found"); > - return -ENODEV; > - } > - > /* Register aux channel */ > anx78xx->aux.name = "DP-AUX"; > anx78xx->aux.dev = &anx78xx->client->dev; > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > index df9370e0ff23..7b841232321f 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1228,11 +1228,6 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge, > return -EINVAL; > } > > - if (!bridge->encoder) { > - DRM_ERROR("Parent encoder object not found"); > - return -ENODEV; > - } > - > if (!dp->plat_data->skip_connector) { > connector = &dp->connector; > connector->polled = DRM_CONNECTOR_POLL_HPD; > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 59e9ad349969..3d09efa4199c 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -2193,11 +2193,6 @@ static int anx7625_bridge_attach(struct drm_bridge *bridge, > if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) > return -EINVAL; > > - if (!bridge->encoder) { > - DRM_DEV_ERROR(dev, "Parent encoder object not found"); > - return -ENODEV; > - } > - > ctx->aux.drm_dev = bridge->dev; > err = drm_dp_aux_register(&ctx->aux); > if (err) { > @@ -2435,11 +2430,6 @@ static void anx7625_bridge_atomic_enable(struct drm_bridge *bridge, > > dev_dbg(dev, "drm atomic enable\n"); > > - if (!bridge->encoder) { > - dev_err(dev, "Parent encoder object not found"); > - return; > - } > - > connector = drm_atomic_get_new_connector_for_encoder(state->base.state, > bridge->encoder); > if (!connector) -- Regards, Laurent Pinchart