From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Elizabeth Figura <zfigura@codeweavers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ntsync: mark driver as "broken" to prevent from building
Date: Wed, 15 May 2024 07:14:54 +0200 [thread overview]
Message-ID: <2024051521-mankind-borough-f773@gregkh> (raw)
In-Reply-To: <12433821.O9o76ZdvQC@watership>
On Tue, May 14, 2024 at 04:45:13PM -0500, Elizabeth Figura wrote:
> On Tuesday, May 14, 2024 2:16:51 AM CDT Greg Kroah-Hartman wrote:
> > The ntsync code is only partially enabled in the kernel at this point in
> > time, creating the device node and that's about it. Don't confuse
> > systems that expect to see a working ntsync interface by teasing it with
> > this basic structure at this point in time, so mark the code as "broken"
> > so that it is not built and enabled just yet.
> >
> > Once the rest of the code is accepted, this will be reverted so that the
> > driver can be correctly built and used, but for now, this is the safest
> > way forward.
>
> Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
>
> --
>
> I was even thinking of suggesting something like this myself. Sorry for
> taking so long to get the rest of the patches into acceptable shape...
No worries at all, I'll go queue this up today. Thanks for the review!
greg k-h
prev parent reply other threads:[~2024-05-15 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 7:16 Greg Kroah-Hartman
2024-05-14 21:45 ` Elizabeth Figura
2024-05-15 5:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024051521-mankind-borough-f773@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®