From: "Mickaël Salaün" <mic@digikod.net>
To: "Günther Noack" <gnoack@google.com>, "Paul Moore" <paul@paul-moore.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Serge E . Hallyn" <serge@hallyn.com>,
nathan@kernel.org, ndesaulniers@google.com,
syzkaller-bugs@googlegroups.com, trix@redhat.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [PATCH v1 0/2] Fix warning in collect_domain_accesses()
Date: Thu, 16 May 2024 20:19:33 +0200 [thread overview]
Message-ID: <20240516181935.1645983-1-mic@digikod.net> (raw)
Hi,
As found by syzbot, there is an issue in the collect_domain_accesses()
function. A WARN_ON_ONCE() can be triggered by processes sandboxed with
Landlock and trying to do a link with a mount root directory. This is
then not a security issue. Moreover, such directory can only be created
with the open_tree(2) syscall by a process with CAP_SYS_ADMIN.
See https://lore.kernel.org/r/000000000000553d3f0618198200@google.com
Regards,
Mickaël Salaün (2):
landlock: Fix d_parent walk
selftests/landlock: Add layout1.refer_mount_root
security/landlock/fs.c | 13 ++++++-
tools/testing/selftests/landlock/fs_test.c | 45 ++++++++++++++++++++++
2 files changed, 56 insertions(+), 2 deletions(-)
base-commit: 5bf9e57e634bd72a97b4b12c87186fc052a6a116
--
2.45.0
next reply other threads:[~2024-05-16 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 18:19 Mickaël Salaün [this message]
2024-05-16 18:19 ` [PATCH v1 1/2] landlock: Fix d_parent walk Mickaël Salaün
2024-05-16 18:19 ` [PATCH v1 2/2] selftests/landlock: Add layout1.refer_mount_root Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516181935.1645983-1-mic@digikod.net \
--to=mic@digikod.net \
--cc=gnoack@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®