From: Chen Ridong <chenridong@huawei.com>
To: <tj@kernel.org>, <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<cyphar@cyphar.com>
Subject: [PATCH -next] cgroup/pids: remove pids_cancel_attach
Date: Fri, 17 May 2024 01:30:01 +0000 [thread overview]
Message-ID: <20240517013001.215350-1-chenridong@huawei.com> (raw)
In pids subsystem, pids_can_attach never returns an error.
Therefore, pids_cancel_attach is unnecessary and is never called.
As a result, it should be removed.
Signed-off-by: Chen Ridong <chenridong@huawei.com>
---
kernel/cgroup/pids.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/kernel/cgroup/pids.c b/kernel/cgroup/pids.c
index 0e5ec7d59b4d..a7a719495547 100644
--- a/kernel/cgroup/pids.c
+++ b/kernel/cgroup/pids.c
@@ -211,24 +211,6 @@ static int pids_can_attach(struct cgroup_taskset *tset)
return 0;
}
-static void pids_cancel_attach(struct cgroup_taskset *tset)
-{
- struct task_struct *task;
- struct cgroup_subsys_state *dst_css;
-
- cgroup_taskset_for_each(task, dst_css, tset) {
- struct pids_cgroup *pids = css_pids(dst_css);
- struct cgroup_subsys_state *old_css;
- struct pids_cgroup *old_pids;
-
- old_css = task_css(task, pids_cgrp_id);
- old_pids = css_pids(old_css);
-
- pids_charge(old_pids, 1);
- pids_uncharge(pids, 1);
- }
-}
-
/*
* task_css_check(true) in pids_can_fork() and pids_cancel_fork() relies
* on cgroup_threadgroup_change_begin() held by the copy_process().
@@ -375,7 +357,6 @@ struct cgroup_subsys pids_cgrp_subsys = {
.css_alloc = pids_css_alloc,
.css_free = pids_css_free,
.can_attach = pids_can_attach,
- .cancel_attach = pids_cancel_attach,
.can_fork = pids_can_fork,
.cancel_fork = pids_cancel_fork,
.release = pids_release,
--
2.34.1
next reply other threads:[~2024-05-17 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 1:30 Chen Ridong [this message]
2024-05-17 1:46 ` Tejun Heo
2024-05-17 1:56 ` 答复: " chenridong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517013001.215350-1-chenridong@huawei.com \
--to=chenridong@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®