From: Lyndon Sanche <lsanche@lyndeno.ca>
To: lsanche@lyndeno.ca
Cc: mario.limonciello@amd.com, pali@kernel.org, W_Armin@gmx.de,
srinivas.pandruvada@linux.intel.com,
ilpo.jarvinen@linux.intel.com, lkp@intel.com,
hdegoede@redhat.com, Yijun.Shen@dell.com,
Matthew Garrett <mjg59@srcf.ucam.org>,
Jonathan Corbet <corbet@lwn.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com
Subject: [PATCH v7 2/3] platform/x86: dell-smbios: Move request functions for reuse
Date: Fri, 17 May 2024 16:42:35 -0600 [thread overview]
Message-ID: <20240517224323.10045-3-lsanche@lyndeno.ca> (raw)
In-Reply-To: <20240517224323.10045-1-lsanche@lyndeno.ca>
Move the dell_send_request and dell_fill_request symbols into smbios-base
so that they can be used in multiple modules.
Signed-off-by: Lyndon Sanche <lsanche@lyndeno.ca>
---
drivers/platform/x86/dell/dell-laptop.c | 23 ------------------
drivers/platform/x86/dell/dell-smbios-base.c | 25 ++++++++++++++++++++
drivers/platform/x86/dell/dell-smbios.h | 5 ++++
3 files changed, 30 insertions(+), 23 deletions(-)
diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c
index 42f7de2b4522..6552dfe491c6 100644
--- a/drivers/platform/x86/dell/dell-laptop.c
+++ b/drivers/platform/x86/dell/dell-laptop.c
@@ -353,29 +353,6 @@ static const struct dmi_system_id dell_quirks[] __initconst = {
{ }
};
-static void dell_fill_request(struct calling_interface_buffer *buffer,
- u32 arg0, u32 arg1, u32 arg2, u32 arg3)
-{
- memset(buffer, 0, sizeof(struct calling_interface_buffer));
- buffer->input[0] = arg0;
- buffer->input[1] = arg1;
- buffer->input[2] = arg2;
- buffer->input[3] = arg3;
-}
-
-static int dell_send_request(struct calling_interface_buffer *buffer,
- u16 class, u16 select)
-{
- int ret;
-
- buffer->cmd_class = class;
- buffer->cmd_select = select;
- ret = dell_smbios_call(buffer);
- if (ret != 0)
- return ret;
- return dell_smbios_error(buffer->output[0]);
-}
-
/*
* Derived from information in smbios-wireless-ctl:
*
diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c
index fbdd12a7cb8d..515c454acfe6 100644
--- a/drivers/platform/x86/dell/dell-smbios-base.c
+++ b/drivers/platform/x86/dell/dell-smbios-base.c
@@ -314,6 +314,31 @@ int dell_smbios_call(struct calling_interface_buffer *buffer)
}
EXPORT_SYMBOL_GPL(dell_smbios_call);
+void dell_fill_request(struct calling_interface_buffer *buffer,
+ u32 arg0, u32 arg1, u32 arg2, u32 arg3)
+{
+ memset(buffer, 0, sizeof(struct calling_interface_buffer));
+ buffer->input[0] = arg0;
+ buffer->input[1] = arg1;
+ buffer->input[2] = arg2;
+ buffer->input[3] = arg3;
+}
+EXPORT_SYMBOL_GPL(dell_fill_request);
+
+int dell_send_request(struct calling_interface_buffer *buffer,
+ u16 class, u16 select)
+{
+ int ret;
+
+ buffer->cmd_class = class;
+ buffer->cmd_select = select;
+ ret = dell_smbios_call(buffer);
+ if (ret != 0)
+ return ret;
+ return dell_smbios_error(buffer->output[0]);
+}
+EXPORT_SYMBOL_GPL(dell_send_request);
+
struct calling_interface_token *dell_smbios_find_token(int tokenid)
{
int i;
diff --git a/drivers/platform/x86/dell/dell-smbios.h b/drivers/platform/x86/dell/dell-smbios.h
index 756c354b1eef..1d6463cca12a 100644
--- a/drivers/platform/x86/dell/dell-smbios.h
+++ b/drivers/platform/x86/dell/dell-smbios.h
@@ -64,6 +64,11 @@ int dell_smbios_call_filter(struct device *d,
struct calling_interface_buffer *buffer);
int dell_smbios_call(struct calling_interface_buffer *buffer);
+void dell_fill_request(struct calling_interface_buffer *buffer,
+ u32 arg0, u32 arg1, u32 arg2, u32 arg3);
+int dell_send_request(struct calling_interface_buffer *buffer,
+ u16 class, u16 select);
+
struct calling_interface_token *dell_smbios_find_token(int tokenid);
enum dell_laptop_notifier_actions {
--
2.42.0
next prev parent reply other threads:[~2024-05-17 22:44 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 17:27 [PATCH] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-04-25 20:07 ` Mario Limonciello
2024-04-25 20:24 ` Lyndon Sanche
2024-04-25 20:28 ` Mario Limonciello
2024-04-25 21:51 ` Srinivas Pandruvada
2024-04-26 0:38 ` Lyndon Sanche
2024-04-26 16:14 ` srinivas pandruvada
2024-04-26 18:23 ` Lyndon Sanche
2024-04-26 18:24 ` srinivas pandruvada
2024-04-25 20:12 ` Pali Rohár
2024-04-25 20:27 ` Lyndon Sanche
2024-04-25 20:31 ` Pali Rohár
2024-04-25 21:07 ` Armin Wolf
2024-04-26 0:54 ` Lyndon Sanche
2024-04-26 2:04 ` [PATCH v2] " Lyndon Sanche
2024-04-26 9:23 ` Ilpo Järvinen
2024-04-26 18:05 ` Lyndon Sanche
2024-05-13 20:09 ` kernel test robot
2024-04-26 6:57 ` [PATCH] " Ilpo Järvinen
2024-04-29 16:48 ` [PATCH v3] " Lyndon Sanche
2024-04-29 17:45 ` Mario Limonciello
2024-04-29 17:51 ` Mario Limonciello
2024-04-29 21:25 ` Lyndon Sanche
2024-04-29 21:21 ` Lyndon Sanche
2024-04-30 10:31 ` Ilpo Järvinen
2024-04-30 18:38 ` Lyndon Sanche
2024-04-30 15:36 ` kernel test robot
2024-05-01 8:16 ` kernel test robot
2024-05-01 16:35 ` kernel test robot
2024-05-01 17:07 ` kernel test robot
2024-05-01 1:14 ` [PATCH v4] " Lyndon Sanche
2024-05-01 1:36 ` Pali Rohár
2024-05-01 1:42 ` Lyndon Sanche
2024-05-01 21:58 ` [PATCH v5] " Lyndon Sanche
2024-05-03 10:19 ` kernel test robot
2024-05-04 1:03 ` Lyndon Sanche
2024-05-06 10:18 ` Hans de Goede
2024-05-07 16:00 ` Lyndon Sanche
2024-05-03 21:19 ` Armin Wolf
2024-05-04 0:59 ` Lyndon Sanche
2024-05-08 14:24 ` Shen, Yijun
2024-05-08 15:53 ` Mario Limonciello
2024-05-11 15:05 ` Shen, Yijun
2024-05-11 15:12 ` Limonciello, Mario
2024-05-11 15:56 ` Shen, Yijun
2024-05-12 17:53 ` Armin Wolf
2024-05-12 17:58 ` Limonciello, Mario
2024-05-12 18:47 ` Armin Wolf
2024-05-12 22:14 ` Limonciello, Mario
2024-05-11 16:02 ` Lyndon Sanche
2024-05-09 15:10 ` Lyndon Sanche
2024-05-11 1:49 ` Lyndon Sanche
2024-05-11 15:22 ` Shen, Yijun
2024-05-11 15:54 ` Lyndon Sanche
2024-05-11 16:12 ` Shen, Yijun
2024-05-11 2:36 ` [PATCH v6 0/2] " Lyndon Sanche
2024-05-11 2:36 ` [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking supported commands Lyndon Sanche
2024-05-11 15:13 ` Limonciello, Mario
2024-05-12 18:00 ` Armin Wolf
2024-05-11 2:36 ` [PATCH v6 2/2] platform/x86: dell-laptop: Implement platform_profile Lyndon Sanche
2024-05-11 15:16 ` Limonciello, Mario
2024-05-11 15:59 ` Lyndon Sanche
[not found] ` <48JCDS.E4RT1F9DTKFU1@lyndeno.ca>
2024-05-12 1:43 ` Limonciello, Mario
2024-05-12 15:25 ` Hans de Goede
2024-05-12 0:14 ` Lyndon Sanche
2024-05-12 18:05 ` Armin Wolf
2024-05-15 17:06 ` Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 0/3] platform/x86: dell: " Lyndon Sanche
2024-05-17 22:42 ` [PATCH v7 1/3] platform/x86: dell-smbios: Add helper for checking supported class Lyndon Sanche
2024-05-17 22:42 ` Lyndon Sanche [this message]
2024-05-17 22:42 ` [PATCH v7 3/3] platform/x86: dell-pc: Implement platform_profile Lyndon Sanche
2024-05-27 9:39 ` Ilpo Järvinen
2024-05-28 16:16 ` Lyndon Sanche
2024-05-21 20:50 ` [PATCH v7 0/3] platform/x86: dell: " Mario Limonciello
2024-05-29 17:47 ` [PATCH v8 " Lyndon Sanche
2024-05-29 17:47 ` [PATCH v8 1/3] platform/x86: dell-smbios: Add helper for checking supported class Lyndon Sanche
2024-05-29 17:47 ` [PATCH v8 2/3] platform/x86: dell-smbios: Move request functions for reuse Lyndon Sanche
2024-05-29 17:47 ` [PATCH v8 3/3] platform/x86: dell-pc: Implement platform_profile Lyndon Sanche
2024-05-30 8:39 ` Ilpo Järvinen
2024-05-31 1:19 ` Lyndon Sanche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517224323.10045-3-lsanche@lyndeno.ca \
--to=lsanche@lyndeno.ca \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=Yijun.Shen@dell.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mario.limonciello@amd.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®