From: Alex Williamson <alex.williamson@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] VFIO updates for v6.10-rc1
Date: Mon, 20 May 2024 17:03:09 -0600 [thread overview]
Message-ID: <20240520170309.76b60123.alex.williamson@redhat.com> (raw)
In-Reply-To: <CAHk-=wiecagwwqGQerx35p+1e2jwjjEbXCphKjPO6Q97DrtYPQ@mail.gmail.com>
On Mon, 20 May 2024 15:05:26 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, 20 May 2024 at 11:12, Alex Williamson
> <alex.williamson@redhat.com> wrote:
> >
> > I've provided the simplified diffstat from a temporary merge branch to
> > avoid the noise of merging QAT dependencies from a branch provided by
> > Herbert.
>
> The diffstat looks good, but the merge itself sucks.
>
> This is the totality of the "explanation" in the merge commit: "".
>
> Yup. That's it. Nothing. Nada.
>
> If you cannot explain *why* you merged a branch from some other tree,
> youi damn well shouldn't have done the merge in the first place.
>
> Merge commits need explanations just like regular commits do. In fact,
> because there isn't some obvious diff attached to them, explanations
> are arguably even more needed.
>
> I've pulled this, but dammit, why does this keep happening?
Sorry. In my case I've looked through logs and I've seen bare merges in
the past and I guess I assumed the reasoning here would be more obvious.
Clearly that's wrong. I'll do better. Thanks,
Alex
next prev parent reply other threads:[~2024-05-20 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 18:12 Alex Williamson
2024-05-20 22:05 ` Linus Torvalds
2024-05-20 23:03 ` Alex Williamson [this message]
2024-05-20 23:09 ` Linus Torvalds
2024-05-20 22:09 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520170309.76b60123.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®