From: Joel Granados <j.granados@samsung.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: <linux-kernel@vger.kernel.org>, Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] utsname: constify ctl_table arguments of utility function
Date: Thu, 23 May 2024 10:19:08 +0200 [thread overview]
Message-ID: <20240523081908.6wdecuconwmmid7d@joelS2.panther.com> (raw)
In-Reply-To: <20240518-sysctl-const-handler-utsname-v1-1-27a6c8813620@weissschuh.net>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On Sat, May 18, 2024 at 03:53:40PM +0200, Thomas Weißschuh wrote:
> The sysctl core is preparing to only expose instances of
...
>
> Cc: Joel Granados <j.granados@samsung.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> ---
> kernel/utsname_sysctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c
> index 76a772072557..04e4513f2985 100644
> --- a/kernel/utsname_sysctl.c
> +++ b/kernel/utsname_sysctl.c
> @@ -15,7 +15,7 @@
>
> #ifdef CONFIG_PROC_SYSCTL
>
> -static void *get_uts(struct ctl_table *table)
> +static void *get_uts(const struct ctl_table *table)
> {
> char *which = table->data;
> struct uts_namespace *uts_ns;
>
> ---
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> change-id: 20240518-sysctl-const-handler-utsname-3f3eec4e6dc3
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
LGTM.
I'll bring this in through the sysctl tree for the next release; unless
folks want it to go in another way. For now it will go to sysctl-testing
waiting for the merge window to be closed.
Reviewed-by: Joel Granados <j.granados@samsung.com>
--
Joel Granados
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2024-05-23 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240518135357eucas1p224f3a8d62089be73990a9bcb7049490f@eucas1p2.samsung.com>
2024-05-18 13:53 ` Thomas Weißschuh
2024-05-23 8:19 ` Joel Granados [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523081908.6wdecuconwmmid7d@joelS2.panther.com \
--to=j.granados@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®