mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Steve Wahl <steve.wahl@hpe.com>
Subject: Re: [Patch v2] x86/head/64: remove redundant check on level2_kernel_pgt's _PAGE_PRESENT bit
Date: Thu, 23 May 2024 12:26:04 +0000	[thread overview]
Message-ID: <20240523122604.2owqxj7fmgudewzk@master> (raw)
In-Reply-To: <fej5k6ikc3biecm5xadxgwv2pflktpjmvrxjhzmhia4p5kipun@ny3swf6kcqwi>

Thanks for comment.

On Thu, May 23, 2024 at 01:33:28PM +0300, Kirill A . Shutemov wrote:
>On Thu, May 23, 2024 at 08:37:52AM +0000, Wei Yang wrote:
>> This patch tries to remove a redundant check on kernel code's PMD
>> _PAGE_PRESENT attribute before fix up.
>
>Tries? s/This patch tries to r/R/

Will use this one.

>
>> Current process looks like this:
>> 
>>     pmd in [0, _text)
>>         unset _PAGE_PRESENT
>>     pmd in [_text, _end]
>>         if (_PAGE_PRESENT)
>>             fix up delta
>>     pmd in (_end, 512)
>>         unset _PAGE_PRESENT
>> 
>> Since we have compiled in _PAGE_PRESENT in this page table, it is not
>> necessary to check _PAGE_PRESENT again before fixing up delta
>
>level2_kernel_pgt compiled with _PAGE_PRESENT set. The check is
>redundant.
>

Will use this one, thanks

>
>-- 
>  Kiryl Shutsemau / Kirill A. Shutemov

-- 
Wei Yang
Help you, Help me

      reply	other threads:[~2024-05-23 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-23  8:37 Wei Yang
2024-05-23 10:33 ` Kirill A . Shutemov
2024-05-23 12:26   ` Wei Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240523122604.2owqxj7fmgudewzk@master \
    --to=richard.weiyang@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=steve.wahl@hpe.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®