From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Suman Ghosh <sumang@marvell.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: micrel: Fix lan8841_config_intr after getting out of sleep mode
Date: Fri, 24 May 2024 08:45:40 +0200 [thread overview]
Message-ID: <20240524064540.azzmscw5k333zerr@DEN-DL-M31836.microchip.com> (raw)
In-Reply-To: <SJ0PR18MB52169D42D6D26244E003BCC8DBF42@SJ0PR18MB5216.namprd18.prod.outlook.com>
The 05/23/2024 16:35, Suman Ghosh wrote:
Hi Suman,
>
> > if (phydev->interrupts == PHY_INTERRUPT_ENABLED) {
> > err = phy_read(phydev, LAN8814_INTS);
> >- if (err)
> >+ if (err < 0)
> [Suman] Hi Horatiu,
> Should we modify this check for phy_write() as well?
I don't think we should modify this check for phy_write.
Because phy_write always return the error code. Which is negative or 0.
> > return err;
> >
> > /* Enable / disable interrupts. It is OK to enable PTP
> >interrupt
> >--
> >2.34.1
> >
>
--
/Horatiu
prev parent reply other threads:[~2024-05-24 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 7:42 Horatiu Vultur
2024-05-23 14:32 ` Andrew Lunn
2024-05-23 18:28 ` Horatiu Vultur
2024-05-23 16:35 ` [EXTERNAL] " Suman Ghosh
2024-05-24 6:45 ` Horatiu Vultur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524064540.azzmscw5k333zerr@DEN-DL-M31836.microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®