mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+2459c1b9fcd39be822b1@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] WARNING in inet_csk_get_port (3)
Date: Mon, 27 May 2024 18:45:12 +0800	[thread overview]
Message-ID: <20240527104512.2559-1-hdanton@sina.com> (raw)
In-Reply-To: <0000000000005736990617c4fa63@google.com>

On Mon, 06 May 2024 01:37:21 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    977b1ef51866 Merge tag 'block-6.9-20240420' of git://git.k..
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=11135520980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  977b1ef51866

--- x/net/ipv4/inet_connection_sock.c
+++ y/net/ipv4/inet_connection_sock.c
@@ -589,7 +589,7 @@ int inet_csk_get_port(struct sock *sk, u
 success:
 	inet_csk_update_fastreuse(tb, sk);
 
-	if (!inet_csk(sk)->icsk_bind_hash)
+	if (tb != inet_csk(sk)->icsk_bind_hash || inet_csk(sk)->icsk_bind2_hash != tb2)
 		inet_bind_hash(sk, tb, tb2, port);
 	WARN_ON(inet_csk(sk)->icsk_bind_hash != tb);
 	WARN_ON(inet_csk(sk)->icsk_bind2_hash != tb2);
--

  parent reply	other threads:[~2024-05-27 10:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06  8:37 syzbot
2024-05-26 12:20 ` syzbot
2024-05-27  8:12   ` Jiri Olsa
2024-05-26 23:27 ` Hillf Danton
2024-05-27  0:19   ` syzbot
2024-05-27 10:45 ` Hillf Danton [this message]
2024-05-27 21:06   ` syzbot
2024-07-23 16:38 ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240527104512.2559-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+2459c1b9fcd39be822b1@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®