mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luke D. Jones" <luke@ljones.dev>
To: hdegoede@redhat.com
Cc: ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Luke D. Jones" <luke@ljones.dev>
Subject: [PATCH 0/9] platform-x86-asus-wmi: multiple fixes, improvements, features
Date: Tue, 28 May 2024 13:36:17 +1200	[thread overview]
Message-ID: <20240528013626.14066-1-luke@ljones.dev> (raw)

This is a series of patches containing either fixes, improvements, or new features.

Most of it is vary straightforward and I'd hope quick and easy to review.
However patch 0003 does a fair bit of work in reducing a series of common
patterns down to a few macros and a more generic store function. This ends
up unifying a lot of things to and making the end result much cleaner to read
plus add future features of the same pattern.

I am unsure if I've got the macros correct. Everything compiles, all is tested
and working correctly - but maybe I could use some guidance on formatting and
style there? Should they be in a header?

The debug statement patch was invaluable for debugging some issues on another
users machine. I will likely add some more debug in future.

The platform_profile issue.. It seems there is a race bewteen asus-wmi and an
AMD driver to register the platform_profile on boot on some laptops. The
asus-wmi driver can live without platform_profile quite fine as the feature
is really just a wrapper around throttle_thermal_policy. But it does raise
the question of "what's going on here?".

Many thanks,
Luke.

Luke D. Jones (9):
  platform/x86: asus-wmi: add debug print in more key places
  platform/x86: asus-wmi: don't fail if platform_profile already
    registered
  platform/x86: asus-wmi: add macros and expose min/max sysfs for ppt
    tunables
  platform/x86: asus-wmi: reduce code duplication with macros
  platform/x86: asus-wmi: use WMI_SIMPLE_SHOW in more places
  platform/x86: asus-wmi: add panel-fhd functionality
  platform/x86: asus-wmi: add enable/disable CPU cores
  platform/x86: asus-wmi: add apu_mem setting
  platform/x86: asus-wmi: add setting dGPU TGP

 .../ABI/testing/sysfs-platform-asus-wmi       |   78 +-
 drivers/platform/x86/asus-wmi.c               | 1248 ++++++++---------
 include/linux/platform_data/x86/asus-wmi.h    |   12 +
 3 files changed, 688 insertions(+), 650 deletions(-)

-- 
2.45.1


             reply	other threads:[~2024-05-28  1:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28  1:36 Luke D. Jones [this message]
2024-05-28  1:36 ` [PATCH 1/9] platform/x86: asus-wmi: add debug print in more key places Luke D. Jones
2024-05-28  1:36 ` [PATCH 2/9] platform/x86: asus-wmi: don't fail if platform_profile already registered Luke D. Jones
2024-05-28  1:36 ` [PATCH 3/9] platform/x86: asus-wmi: add macros and expose min/max sysfs for ppt tunables Luke D. Jones
2024-05-28  8:50   ` Ilpo Järvinen
2024-06-04  5:14   ` kernel test robot
2024-05-28  1:36 ` [PATCH 4/9] platform/x86: asus-wmi: reduce code duplication with macros Luke D. Jones
2024-05-28  8:55   ` Ilpo Järvinen
2024-05-28  9:03   ` Ilpo Järvinen
2024-05-28  1:36 ` [PATCH 5/9] platform/x86: asus-wmi: use WMI_SIMPLE_SHOW in more places Luke D. Jones
2024-05-28  9:06   ` Ilpo Järvinen
2024-05-28  1:36 ` [PATCH 6/9] platform/x86: asus-wmi: add panel-fhd functionality Luke D. Jones
2024-05-28  9:18   ` Ilpo Järvinen
2024-05-28  1:36 ` [PATCH 7/9] platform/x86: asus-wmi: add enable/disable CPU cores Luke D. Jones
2024-05-28  9:27   ` Ilpo Järvinen
2024-05-28 21:37     ` Luke Jones
2024-05-28  1:36 ` [PATCH 8/9] platform/x86: asus-wmi: add apu_mem setting Luke D. Jones
2024-05-28  2:19   ` Limonciello, Mario
2024-05-28  2:40     ` Luke Jones
2024-05-28 13:27       ` Mario Limonciello
2024-05-28 21:04         ` Luke Jones
2024-05-28 21:16           ` Mario Limonciello
2024-05-28 21:34             ` Luke Jones
2024-05-28 21:36               ` Mario Limonciello
2024-05-28 21:37               ` Mario Limonciello
2024-05-28  1:36 ` [PATCH 9/9] platform/x86: asus-wmi: add setting dGPU TGP Luke D. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528013626.14066-1-luke@ljones.dev \
    --to=luke@ljones.dev \
    --cc=corentin.chary@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®