From: Eric Curtin <ecurtin@redhat.com>
To: linux-unionfs@vger.kernel.org (open list:OVERLAY FILESYSTEM)
Cc: Alexander Larsson <alexl@redhat.com>,
Eric Curtin <ecurtin@redhat.com>, Wei Wang <weiwang@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
linux-unionfs@vger.kernel.org (open list:OVERLAY FILESYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] ovl: change error message to info for empty lowerdir
Date: Tue, 28 May 2024 10:02:40 +0100 [thread overview]
Message-ID: <20240528090244.6746-1-ecurtin@redhat.com> (raw)
In some deployments, an empty lowerdir is not considered an error.
The current implementation logs this scenario as an error during boot,
which can be misleading and cause unnecessary concern for users. This
commit changes the log level from pr_err to pr_info to reflect the
non-error nature of an empty lowerdir in these cases.
Reported-by: Wei Wang <weiwang@redhat.com>
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
---
fs/overlayfs/params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index 4860fcc4611bb..53170d73bb79c 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -231,7 +231,7 @@ static int ovl_mount_dir_noesc(const char *name, struct path *path)
int err = -EINVAL;
if (!*name) {
- pr_err("empty lowerdir\n");
+ pr_info("empty lowerdir\n");
goto out;
}
err = kern_path(name, LOOKUP_FOLLOW, path);
--
2.45.0
next reply other threads:[~2024-05-28 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 9:02 Eric Curtin [this message]
2024-05-28 10:34 ` Miklos Szeredi
2024-05-28 10:54 ` Eric Curtin
2024-05-28 11:34 ` Miklos Szeredi
[not found] ` <CAL7ro1Hm7EOxKUv9U5vEMbe2Ui2oaCdM0b2Xbm0wbdZ52+JV2w@mail.gmail.com>
2024-05-28 12:25 ` Eric Curtin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528090244.6746-1-ecurtin@redhat.com \
--to=ecurtin@redhat.com \
--cc=alexl@redhat.com \
--cc=amir73il@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=weiwang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®