From: Borislav Petkov <bp@alien8.de>
To: John Allen <john.allen@amd.com>
Cc: linux-edac@vger.kernel.org, tony.luck@intel.com,
yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
avadhut.naik@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH v4 2/4] RAS/AMD/ATL: Expand helpers for adding and removing base and hole
Date: Tue, 28 May 2024 12:07:14 +0200 [thread overview]
Message-ID: <20240528100714.GEZlWs0qL8tmCb9Mw3@fat_crate.local> (raw)
In-Reply-To: <20240506154605.71814-3-john.allen@amd.com>
On Mon, May 06, 2024 at 03:46:03PM +0000, John Allen wrote:
> +u64 add_base_and_hole(struct addr_ctx *ctx, u64 addr)
> {
> - ctx->ret_addr += get_base_addr(ctx);
> -
> - if (add_legacy_hole(ctx))
> - return -EINVAL;
> + addr += get_base_addr(ctx);
> + return add_legacy_hole(ctx, addr);
return add_legacy_hole(ctx, addr + get_base_addr(ctx));
That's still readable. :)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2024-05-28 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:46 [PATCH v4 0/4] RAS: ATL: DF 4.5 NP2 Denormalization John Allen
2024-05-06 15:46 ` [PATCH v4 1/4] RAS/AMD/ATL: Read DRAM hole base early John Allen
2024-05-28 8:16 ` Borislav Petkov
2024-06-05 18:47 ` John Allen
2024-05-06 15:46 ` [PATCH v4 2/4] RAS/AMD/ATL: Expand helpers for adding and removing base and hole John Allen
2024-05-28 10:07 ` Borislav Petkov [this message]
2024-05-06 15:46 ` [PATCH v4 3/4] RAS/AMD/ATL: Validate address map when information is gathered John Allen
2024-05-28 10:11 ` Borislav Petkov
2024-05-06 15:46 ` [PATCH v4 4/4] RAS/AMD/ATL: Implement DF 4.5 NP2 denormalization John Allen
2024-05-28 10:23 ` Borislav Petkov
2024-06-03 21:01 ` John Allen
2024-06-03 21:06 ` Borislav Petkov
2024-05-08 15:51 ` [PATCH v4 0/4] RAS: ATL: DF 4.5 NP2 Denormalization Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528100714.GEZlWs0qL8tmCb9Mw3@fat_crate.local \
--to=bp@alien8.de \
--cc=avadhut.naik@amd.com \
--cc=john.allen@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muralidhara.mk@amd.com \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®